Compiler: use-js-string enabled by default

Author: hhugo

compiler/lib/config.ml

@@ -80,7 +80,7 @@ module Flag = struct
 
   let safe_string = o ~name:"safestring" ~default:true
 
-  let use_js_string = o ~name:"use-js-string" ~default:false
+  let use_js_string = o ~name:"use-js-string" ~default:true
 
   let check_magic = o ~name:"check-magic-number" ~default:true
 

compiler/tests-jsoo/test_obj.ml

@@ -49,7 +49,9 @@ let%expect_test "dup" =
   let s = "Hello" in
   let s' : string = Obj.obj (Obj.dup (Obj.repr s)) in
   print_bool (s = s');
-  print_bool (s != s');
+  (match Sys.backend_type with
+  | Other "js_of_ocaml" -> print_bool (s = s')
+  | Native | Bytecode | Other _ -> print_bool (s != s'));
   [%expect {|
     true
     true |}];

lib/tests/test_poly_compare.ml

@@ -67,7 +67,7 @@ let%expect_test "number comparison" =
 let%expect_test "string comparison" =
   assert (Pack (Js.Unsafe.js_expr "String(2)") = Pack (Js.string "2"));
   assert (Pack (Js.Unsafe.js_expr "String('abc')") = Pack (Js.string "abc"));
-  assert (Pack (Js.Unsafe.js_expr "new String('abc')") = Pack (Js.string "abc"));
+  assert (Pack (Js.Unsafe.js_expr "new String('abc')") <> Pack (Js.string "abc"));
   assert (Pack (Js.Unsafe.js_expr "String(1)") <> Pack (Js.string "2"));
   assert (Pack (Js.Unsafe.js_expr "String('abcd')") <> Pack (Js.string "abc"));
   assert (Pack (Js.Unsafe.js_expr "new String('abcd')") <> Pack (Js.string "abc"));