Add --no-types-module option

Author: cannorin

src/Targets/ReScript/Common.fs

@@ -72,12 +72,14 @@ type Options =
   // output options
   abstract outputDir: string option with get
   abstract resi: bool with get
-  // code generator options
+  // typer options
   abstract numberAsInt: bool with get, set
   abstract subtyping: Subtyping list with get, set
   abstract inheritWithTags: FeatureFlag with get, set
+  // code generator options
   abstract simplify: Simplify list with get, set
   abstract readableNames: bool with get, set
+  abstract noTypesModule: bool with get, set
 
 module Options =
   open Fable.Core.JsInterop
@@ -203,7 +205,8 @@ module Options =
       .group(
         !^ResizeArray[
           "simplify";
-          "human-readable-anonymous-interface-names";
+          "readable-names";
+          "no-types-module"
         ],
         "Code Generator Options:")
       .addCommaSeparatedStringSet(
@@ -219,6 +222,12 @@ module Options =
         descr="Try to use more readable names instead of AnonymousInterfaceN.",
         defaultValue = false
       )
+      .addFlag(
+        "no-types-module",
+        (fun (o: Options) -> o.noTypesModule),
+        descr="Unsafe. Do not emit Types module even if there are recursive modules.",
+        defaultValue = false
+      )
 
       .middleware(!^validate)
 
@@ -231,4 +240,4 @@ type Output = {
   res: text
 }
 
-let [<ImportDefault("../../../dist_rescript/src/ts2ocaml.res?raw")>] stdlib: string = jsNative
+let [<ImportDefault("../../../dist_rescript/src/ts2ocaml.res?raw")>] stdlib: string = jsNative

src/Targets/ReScript/Writer.fs

@@ -929,11 +929,9 @@ let rec emitClass flags overrideFunc (ctx: Context) (current: StructuredText) (c
               | InheritingType.Other t -> [t])
             |> List.map (getKnownTypes innerCtx)
 
-        // We only need the anonymous interfaces that appear in the members
         yield
           c.members
           |> Seq.collect (snd >> findTypesInClassMember (knownTypeFinder innerCtx) ())
-          // |> Seq.filter (function KnownType.AnonymousInterface _ -> true | _ -> false)
           |> Set.ofSeq
 
         yield!
@@ -1617,8 +1615,8 @@ module EmitModuleResult =
   let empty : EmitModuleResult =
     {| imports = []; types = []; impl = []; intf = []; comments = [] |}
 
-let rec emitModule (dt: DependencyTrie<string>) flags ctx st =
-  let isLinear = DependencyTrie.isLinear dt // compute only once
+let rec emitModule (dt: DependencyTrie<string>) flags (ctx: Context) st =
+  let isLinear = ctx.options.noTypesModule || DependencyTrie.isLinear dt // compute only once
   let rec go (flags: EmitModuleFlags) (ctx: Context) (st: StructuredText) : EmitModuleResult =
     let renamer = new OverloadRenamer()
     let children =
@@ -1750,6 +1748,20 @@ let rec emitModule (dt: DependencyTrie<string>) flags ctx st =
       ]
 
     let impl =
+      let fixmeRecursiveModules (ms: TextModule list) =
+        match ms with
+        | [] -> []
+        | [m] -> [Statement.moduleVal m]
+        | _ when ctx.options.noTypesModule ->
+          [ yield
+              commentStr (
+                sprintf "FIXME: start of recursive definitions (%s)"
+                  (ms |> List.map (fun m -> m.name) |> String.concat ", ")
+              )
+            yield! Statement.moduleValMany ms
+            yield commentStr "FIXME: end of recursive definitions" ]
+        | _ -> Statement.moduleValMany ms
+
       let children =
         children
         |> List.filter (fun (_, _, c) -> c.impl |> List.isEmpty |> not)
@@ -1760,7 +1772,7 @@ let rec emitModule (dt: DependencyTrie<string>) flags ctx st =
             else
               c.imports @ c.impl
           {| k with content = content; comments = c.comments |})
-        |> Statement.moduleSCC dt Statement.moduleValMany Statement.moduleValMany ctx
+        |> Statement.moduleSCC dt fixmeRecursiveModules Statement.moduleValMany ctx
       let typeDefs =
         items |> List.choose (function
           | TypeAliasText t -> Some t