Merge pull request #449 from oddbit/copilot/move-example-app-build-step

Move example app build to PR workflow, simplify publish workflow

Author: DennisAlund

.github/workflows/build_deploy.yml

@@ -5,113 +5,11 @@ on:
       - "v[0-9]+.[0-9]+.[0-9]+*"
 
 jobs:
-  build_example:
-    name: Build Example App
-    runs-on: ${{ matrix.os }}
-    timeout-minutes: 60
-    strategy:
-      fail-fast: true
-      matrix:
-        platform:
-          - apk
-          - ios
-        os:
-          - ubuntu-latest
-          - macos-latest
-        exclude:
-          # Skip build combinations where Android is attempted to build on MacOS
-          # and iOS attempt to build on Ubuntu.
-          - os: macos-latest
-            platform: apk
-          - os: ubuntu-latest
-            platform: ios
-
-          # TODO(Dennis): iOS builds aren't properly configured yet. Fix and
-          # uncomment this exclusion
-          # https://github.com/oddbit/flutter_facebook_app_events/actions/runs/3365684172/jobs/5581387481
-          - platform: ios
-
-    steps:
-      - uses: actions/checkout@v4
-
-      # Ensure a compatible JDK for modern Android Gradle Plugin
-      - name: Set up Java 17
-        if: matrix.platform == 'apk'
-        uses: actions/setup-java@v4
-        with:
-          distribution: temurin
-          java-version: "17"
-
-      - name: Set up Flutter
-        uses: subosito/flutter-action@v2
-        with:
-          channel: "stable"
-          cache: true
-
-      - run: flutter --version
-
-      # Resolve root package (plugin) dependencies
-      - name: Flutter pub get (root)
-        run: flutter pub get
-
-      # Resolve example app dependencies explicitly
-      - name: Flutter pub get (example)
-        if: matrix.platform == 'apk'
-        working-directory: ./example
-        run: flutter pub get
-
-      - name: Configure iOS build environment
-        if: matrix.platform == 'ios'
-        run: |
-          echo "FLUTTER_EXTRA_PARAMS=--no-codesign" >> $GITHUB_ENV
-
-      - name: Activate iOS Pods Cache
-        uses: actions/cache@v4
-        if: matrix.platform == 'ios'
-        with:
-          path: example/ios/Pods
-          key: ${{ runner.os }}-pods-${{ hashFiles('ios/Podfile.lock') }}
-          restore-keys: ${{ runner.os }}-pods-
-
-      - run: flutter doctor
-
-      # Start from a clean state to avoid watcher/gradle cache oddities
-      - name: Flutter clean (example)
-        if: matrix.platform == 'apk'
-        working-directory: ./example
-        run: flutter clean
-
-      - name: Build Flutter
-        working-directory: ./example
-        run: >-
-          flutter
-          build ${{ matrix.platform }}
-          ${{ env.FLUTTER_EXTRA_PARAMS }}
-
-      # Help verify Android outputs and surface them as artifacts
-      - name: List Android outputs
-        if: matrix.platform == 'apk'
-        working-directory: ./example
-        run: |
-          echo "Listing build/app/outputs:"
-          ls -R build/app/outputs || true
-
-      - name: Upload APK artifact
-        if: matrix.platform == 'apk'
-        uses: actions/upload-artifact@v4
-        with:
-          name: example-apk
-          path: |
-            example/build/app/outputs/flutter-apk/*.apk
-            example/build/app/outputs/apk/**/*.apk
-            example/build/**/outputs/**/*.apk
-
   publish:
     name: Publish Plugin
     runs-on: ubuntu-latest
     permissions:
       id-token: write
-    needs: build_example
     steps:
       - uses: actions/checkout@v4
 

.github/workflows/pr_build_example.yml

@@ -26,10 +26,6 @@ jobs:
 
       - name: Set up Android SDK
         uses: android-actions/setup-android@v3
-        with:
-          api-level: 34
-          build-tools: 34.0.0
-          cache: true
 
       - name: Set up Flutter
         uses: subosito/flutter-action@v2
@@ -53,19 +49,3 @@ jobs:
       - name: Build example APK (debug, verbose)
         working-directory: example
         run: flutter build apk --debug -v
-
-      - name: List Android outputs
-        working-directory: example
-        run: |
-          echo "Listing build/app/outputs:"
-          ls -R build/app/outputs || true
-
-      - name: Upload APK artifact
-        uses: actions/upload-artifact@v4
-        with:
-          name: example-app-debug-apk
-          path: |
-            example/build/app/outputs/flutter-apk/app-debug.apk
-            example/build/app/outputs/apk/debug/*.apk
-            example/build/**/outputs/**/*.apk
-          if-no-files-found: warn

example/android/build.gradle

@@ -1,16 +1,14 @@
 // Top-level build file where you can add configuration options common to all sub-projects/modules.
-
 buildscript {
+    ext.kotlin_version = "1.9.24"
     repositories {
         google()
         mavenCentral()
     }
 
     dependencies {
-        // Modern Android Gradle Plugin
         classpath 'com.android.tools.build:gradle:8.5.2'
-        // Modern Kotlin
-        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.24"
+        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
     }
 }
 
@@ -21,8 +19,14 @@ allprojects {
     }
 }
 
-// Custom clean task to ensure all build directories are deleted
-tasks.register('clean', Delete) {
+rootProject.buildDir = "../build"
+subprojects {
+    project.buildDir = "${rootProject.buildDir}/${project.name}"
+}
+subprojects {
+    project.evaluationDependsOn(":app")
+}
+
+tasks.register("clean", Delete) {
     delete rootProject.buildDir
-    subprojects.each { delete it.buildDir }
-}
+}

example/android/gradle/wrapper/gradle-wrapper.properties

@@ -3,5 +3,5 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-# AGP 8.5.x pairs with Gradle 8.7
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
+
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.6-bin.zip