Skip to content

Commit 7bfea7e

Browse files
authored
chore(CI): temporarily omit nio (#495)
* chore(CI): temporarily omit `nio` * fix around `benches_rt` * fix Taskfile's `status` for benches (skip control)
1 parent 3d84699 commit 7bfea7e

7 files changed

Lines changed: 17 additions & 12 deletions

File tree

Taskfile.yaml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@ version: 3
33
vars:
44
maybe_nightly: { sh: cargo version | grep -q 'nightly' && echo 'nightly' || echo '' }
55

6+
# 2025-08-07
7+
# temporarily omitting `nio` runtime from CI tasks
8+
# because the latest published version of `nio` (0.0.1) fails to build
9+
# (ref: for example, https://github.com/ohkami-rs/ohkami/pull/493#issuecomment-3146636452)
10+
611
tasks:
712
CI:
813
deps:
@@ -18,7 +23,7 @@ tasks:
1823
deps:
1924
- task: test:tls
2025
- task: test:no_rt
21-
- for: [tokio, smol, nio, glommio, lambda, worker]
26+
- for: [tokio, smol, glommio, lambda, worker] # [tokio, smol, nio, glommio, lambda, worker]
2227
task: test:rt
2328
vars: { rt: '{{.ITEM}}' }
2429
test:other:
@@ -32,23 +37,23 @@ tasks:
3237
deps:
3338
- task: check:tls
3439
- task: check:no_rt
35-
- for: [tokio, smol, nio, glommio, lambda]
40+
- for: [tokio, smol, glommio, lambda] # [tokio, smol, nio, glommio, lambda]
3641
task: check:rt-native_target
3742
vars: { rt: '{{.ITEM}}' }
3843
- task: check:rt_worker
3944

4045
bench:dryrun:
4146
status:
42-
- (! cargo version | grep -q 'nightly')
47+
- '[ "{{.maybe_nightly}}" != nightly ]' # skip if not nightly
4348
cmds:
4449
- cd benches && cargo bench --features DEBUG --no-run
4550
- cd benches_rt/vs_actix-web && cargo check
46-
- for: [tokio, smol, nio, glommio]
51+
- for: [tokio, smol, glommio] # [tokio, smol, nio, glommio]
4752
cmd: cd benches_rt/{{.ITEM}} && cargo check
4853

4954
bench:
5055
status:
51-
- (! cargo version | grep -q 'nightly')
56+
- '[ "{{.maybe_nightly}}" != nightly ]' # skip if not nightly
5257
dir: ./benches
5358
cmds:
5459
- task: bench:dryrun

benches_rt/glommio/src/bin/param.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use glommio::{LocalExecutorPoolBuilder, PoolPlacement, CpuSet};
44

55

66
#[inline(always)]
7-
async fn echo_id(id: String) -> String {
7+
async fn echo_id(Path(id): Path<String>) -> String {
88
id
99
}
1010

benches_rt/nio/src/bin/param.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ use ohkami::prelude::*;
44
async fn main() {
55
Ohkami::new((
66
"/user/:id"
7-
.GET(|id: String| async {id}),
7+
.GET(|Path(id): Path<String>| async {id}),
88
)).howl("0.0.0.0:3000").await
99
}

benches_rt/smol/src/bin/param.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use ohkami::prelude::*;
22

33

44
#[inline(always)]
5-
async fn echo_id(id: String) -> String {
5+
async fn echo_id(Path(id): Path<String>) -> String {
66
id
77
}
88

benches_rt/tokio/src/bin/hello.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
use ohkami::prelude::*;
2-
use ohkami::format::Json;
2+
use ohkami::format::{Path, Json};
33

44
#[derive(Serialize)]
55
struct Message {
66
message: String
77
}
88

9-
async fn hello(name: &str) -> Json<Message> {
9+
async fn hello(Path(name): Path<&str>) -> Json<Message> {
1010
Json(Message {
1111
message: format!("Hello, {name}!")
1212
})

benches_rt/tokio/src/bin/param.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@ fn main() {
88
.expect("Failed building the Runtime")
99
.block_on(Ohkami::new((
1010
"/user/:id"
11-
.GET(|id: String| async {id}),
11+
.GET(|Path(id): Path<String>| async {id}),
1212
)).howl("0.0.0.0:3000"))
1313
}

benches_rt/tokio/src/bin/sleep.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
use ohkami::prelude::*;
22

3-
async fn sleeping_hello(secs: u64) -> &'static str {
3+
async fn sleeping_hello(Path(secs): Path<u64>) -> &'static str {
44
tokio::time::sleep(std::time::Duration::from_secs(secs)).await;
55
"Hello, sleep!"
66
}

0 commit comments

Comments
 (0)