Skip to content

Incorrect button behaviour for mincome notification modal #2922

@corrideat

Description

@corrideat

Problem

This is a follow up to PR #2921 and issue #2919.

Clicking on the now-working notification about a mincome change, I get a prompt that presumably is to update my mincome details.

Image

Clicking on 'No' takes me to the Income Details page to update my mincome details (although 'Yes, I do' is selected instead of 'No, I don't'), but clicking on 'Yes' simply dismisses the prompt. I believe both 'yes' and 'no' should send me to Income Details (maybe with a third button to dismiss the prompt).

Solution

Update the modal so that it works. There are a few options that I see:

  1. Have both buttons send you to the Income Details page, maybe also fixing it so that 'Yes' or 'No' preselect the correct answer on this page to the first question (Do you make..?)
  2. Like 1 above, but also add a third button to dismiss the modal
  3. Change the modal text so that the options read something like 'Skip' / 'Cancel' / 'Not now' and 'Update my income details'

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions