Weird message sync issue (+ messages out of order)

[taoeffect]

Problem

• I uploaded an attachment on my phone to a chat.
• Then I visited the site on another device, where I think it was already loaded to that very chat. I did not see the attachment appear.
• I typed a message and hit send. The message was grey for a bit and then suddenly appeared above the message with the attachment (when it should have appeared below)

In the console I saw these errors:

Solution

The message appearing out of order thing is something I saw in a separate circumstance as well (during a demo of group income). Messages should never appear out of order in the chat, but it seems something about the way the chat renders them causes this to sometimes happen.

So this is really two issues:

1. Why didn't the attachment appear when I visited the site? Seems like websocket weirdness maybe? Or maybe a bug in sync?
2. This is the main issue: messages should never appear out of order

Also, can you check what those Invalid height messages are about? Are they real errors (in which case, what's the fix?) or should they be warnings?

[corrideat]

The steps indicated are insufficient to determine whether this is a bug or not.

Why didn't the attachment appear when I visited the site? Seems like websocket weirdness maybe? Or maybe a bug in sync?

Insufficient information, but a web socket issue could be it.

This is the main issue: messages should never appear out of order

Insufficient information, but order is a relative thing. Since the message didn't exist in the state and was seemingly fetched after sending it, the order shown looks in fact to be correct (although when it's no longer pending it should be shown at the end). If you're saying that pending messages should always be shown at the bottom, that's a slightly different issue.

Also, can you check what those Invalid height messages are about? Are they real errors (in which case, what's the fix?) or should they be warnings?

They're real errors pointing to the state not being fully in sync and likely related to the remainder of the issue. We can look at the socket and sync and see if there are any issues. Ultimately, we can't prevent every sync issue, but we do have some weird WS issues that we shouldn't have (like the WS sometimes being 'offline' when many messages are being loaded)

[taoeffect]

Insufficient information, but order is a relative thing. Since the message didn't exist in the state and was seemingly fetched after sending it, the order shown looks in fact to be correct (although when it's no longer pending it should be shown at the end). If you're saying that pending messages should always be shown at the bottom, that's a slightly different issue.

The test message that was sent turned white (no longer pending) and was above the attachment message in this history when it should have been below.

As a separate question, yes I do think that the pending messages should always be shown at the bottom, I think that makes intuitive sense since they haven't actually made their way into the history and should also appear where they actually do end up.

[corrideat]

The test message that was sent turned white (no longer pending) and was above the attachment message in this history when it should have been below.

Thanks for clarifying that. That indeed is a bug.

As a separate question, yes I do think that the pending messages should always be shown at the bottom, I think that makes intuitive sense since they haven't actually made their way into the history and should also appear where they actually do end up.

I can see that making sense. I can also see that being confusing to users as the positioning of pending messages is re-arranged.

[taoeffect]

I can see that making sense. I can also see that being confusing to users as the positioning of pending messages is re-arranged.

It depends on how it's implemented. If pending messages are just kept at the bottom in a special section, there should be no "rearranging" visible. Newer messages will just immediately appear above them.

EDIT: there could even be an x button that cancels the message when tapped... might make sense if the message is pending for a while and the conversation moves on to allow the user to cancel it.