fix: pane groups incompletely reset after scroll #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nouzbe
commented
Apr 24, 2025
| @@ -129,7 +129,10 @@ export default class ScrollSync extends Component { | |||
| this.syncScrollPosition(scrolledPane, pane) | |||
| /* Re-attach event listeners after we're done scrolling */ | |||
| window.requestAnimationFrame(() => { | |||
| this.addEvents(pane, groups) | |||
There was a problem hiding this comment.
The cause of the problem is that pane would belong to multiple groups, and the event listeners would only be reset to some of these groups here.
In reference to the GIF in the linked issue, the pane in pink belongs to ["horizontal", "vertical"]. But when scrolling vertically on the blue grid, we would reset the event listeners of the pink grid to "vertical" and therefore break the horizontal scrolling synchronization between the pink and black grids.
okonet
approved these changes
Apr 25, 2025
|
🎉 This PR is included in version 0.11.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #95.