Skip to content

Removing warnings on Strict Mode and more #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Conversation

elixs
Copy link
Contributor

@elixs elixs commented Jun 2, 2022

  • Deleted leftovers from old context api (removes warning)
  • Removed use of findDOMNode (removes warning)
  • ScrollSyncPane "attachTo" now uses a reference (React.createRef or useRef)
  • ScrollSyncPane "attachTo" can be changed dynamically
  • ScrollSyncPane "enabled" can be changed dynamically
  • ScrollSyncPane "attachTo" have priority over child component. If no "attachTo" is provided, a single child component with ref support is expected (for example a div or input, not a React.Fragment or more that one child)

@okonet
Copy link
Owner

okonet commented Jun 5, 2022

I wonder how is this PR relevant since #74 has been merged.

@elixs
Copy link
Contributor Author

elixs commented Jun 7, 2022

I wonder how is this PR relevant since #74 has been merged.

This PR is built upon #74 because it left some code behind that shows a console warning (e2e441c)
Also I removed another console warning by replacing findDOMNode which is now deprecated.
And as I was fixing these warnings I also added support for changing the props attachTo and enabled at runtime (check componentDidUpdate from 772bd5c)

@okonet
Copy link
Owner

okonet commented Jun 7, 2022

Okay thanks I got it now.

@okonet okonet merged commit dcdcf37 into okonet:master Jun 7, 2022
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

🎉 This PR is included in version 0.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants