Skip to content

Commit dfa74a7

Browse files
added comments for clarity
1 parent 96c53b2 commit dfa74a7

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

src/v2/view-builder/views/nfcPin/EnrollNfcPinView.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const DeviceChallengeBody = BaseOktaVerifyChallengeView.extend({
3131
});
3232

3333
/**
34-
* Phase 3: PIN creation — same pattern as EnrollAuthenticatorPasswordView
34+
* Phase 2: PIN creation — same pattern as EnrollAuthenticatorPasswordView
3535
*/
3636
const PinCreateBody = BaseForm.extend({
3737
className: 'nfc-pin-create',

src/v3/src/transformer/i18n/transformLaunchAuthenticatorButton.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ export const transformLaunchAuthenticatorButton: TransformStepFn = (
2727
predicate: (element) => element.type === 'LaunchAuthenticatorButton',
2828
callback: (element) => {
2929
const { options } = element as LaunchAuthenticatorButtonElement;
30+
// Supports authenticator-specific labels (e.g. NFC PIN uses 'oie.nfc_pin.launch.button')
31+
// Falls back to OktaVerify label for backward compatibility
3032
const labelKey = options?.i18nKey || 'oktaVerify.button';
3133
addTranslation({
3234
element,

src/v3/src/transformer/nfcPin/transformNfcPinCreate.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export const transformNfcPinCreate: IdxStepTransformer = ({
4646
// PIN settings — map to PasswordSettings format
4747
const rawSettings = (
4848
relatesTo?.value?.settings
49-
// @ts-ignore enrollmentAuthenticator may not be typed
49+
// @ts-expect-error enrollmentAuthenticator may not be typed
5050
|| context?.enrollmentAuthenticator?.value?.settings
5151
|| {}
5252
) as { minLength?: number; maxLength?: number };

0 commit comments

Comments
 (0)