clearer environment debugging information

Author: olekukonko

tablewriter.go

@@ -4,7 +4,6 @@ import (
 	"bytes"
 	"io"
 	"math"
-	"os"
 	"reflect"
 	"runtime"
 	"strings"
@@ -419,7 +418,6 @@ func (t *Table) Options(opts ...Option) *Table {
 	}
 
 	// force debugging mode if set
-	// This should  be move away form WithDebug
 	if t.config.Debug {
 		t.logger.Enable()
 		t.logger.Resume()
@@ -434,11 +432,28 @@ func (t *Table) Options(opts ...Option) *Table {
 	goArch := runtime.GOARCH
 	numCPU := runtime.NumCPU()
 
-	t.logger.Infof("Environment: LC_CTYPE=%s, LANG=%s, TERM=%s", os.Getenv("LC_CTYPE"), os.Getenv("LANG"), os.Getenv("TERM"))
-	t.logger.Infof("Go Runtime: Version=%s, OS=%s, Arch=%s, CPUs=%d", goVersion, goOS, goArch, numCPU)
+	// Use the new struct-based info.
+	// No type assertions or magic strings needed.
+	info := twwidth.Debugging()
+
+	t.logger.Infof("Go Runtime: Version=%s, OS=%s, Arch=%s, CPUs=%d",
+		goVersion, goOS, goArch, numCPU)
+
+	t.logger.Infof("Environment: LC_CTYPE=%s, LANG=%s, TERM=%s, TERM_PROGRAM=%s",
+		info.Raw.LC_CTYPE,
+		info.Raw.LANG,
+		info.Raw.TERM,
+		info.Raw.TERM_PROGRAM,
+	)
+
+	t.logger.Infof("East Asian Detection: Auto=%v, Mode=%s, ModernEnv=%v, CJKLocale=%v",
+		info.AutoUseEastAsian,
+		info.DetectionMode,
+		info.Derived.IsModernEnv,
+		info.Derived.IsCJKLocale,
+	)
 
 	// send logger to renderer
-	// this will overwrite the default logger
 	t.renderer.Logger(t.logger)
 	return t
 }

zoo.go

@@ -991,7 +991,7 @@ func (t *Table) calculateContentMaxWidth(colIdx int, config tw.CellConfig, padLe
 		constraintTotalCellWidth := 0
 		hasConstraint := false
 
-		// 1. Check new Widths.PerColumn (highest priority)
+		// Check new Widths.PerColumn (highest priority)
 		if t.config.Widths.Constrained() {
 
 			if colWidth, ok := t.config.Widths.PerColumn.OK(colIdx); ok && colWidth > 0 {
@@ -1001,15 +1001,15 @@ func (t *Table) calculateContentMaxWidth(colIdx int, config tw.CellConfig, padLe
 					colIdx, constraintTotalCellWidth)
 			}
 
-			// 2. Check new Widths.Global
+			// Check new Widths.Global
 			if !hasConstraint && t.config.Widths.Global > 0 {
 				constraintTotalCellWidth = t.config.Widths.Global
 				hasConstraint = true
 				t.logger.Debugf("calculateContentMaxWidth: Using Widths.Global = %d", constraintTotalCellWidth)
 			}
 		}
 
-		// 3. Fall back to legacy ColMaxWidths.PerColumn (backward compatibility)
+		// Fall back to legacy ColMaxWidths.PerColumn (backward compatibility)
 		if !hasConstraint && config.ColMaxWidths.PerColumn != nil {
 			if colMax, ok := config.ColMaxWidths.PerColumn.OK(colIdx); ok && colMax > 0 {
 				constraintTotalCellWidth = colMax
@@ -1019,15 +1019,15 @@ func (t *Table) calculateContentMaxWidth(colIdx int, config tw.CellConfig, padLe
 			}
 		}
 
-		// 4. Fall back to legacy ColMaxWidths.Global
+		// Fall back to legacy ColMaxWidths.Global
 		if !hasConstraint && config.ColMaxWidths.Global > 0 {
 			constraintTotalCellWidth = config.ColMaxWidths.Global
 			hasConstraint = true
 			t.logger.Debugf("calculateContentMaxWidth: Using legacy ColMaxWidths.Global = %d",
 				constraintTotalCellWidth)
 		}
 
-		// 5. Fall back to table MaxWidth if auto-wrapping
+		// Fall back to table MaxWidth if auto-wrapping
 		if !hasConstraint && t.config.MaxWidth > 0 && config.Formatting.AutoWrap != tw.WrapNone {
 			constraintTotalCellWidth = t.config.MaxWidth
 			hasConstraint = true
@@ -1224,7 +1224,7 @@ func (t *Table) convertToString(value interface{}) string {
 func (t *Table) convertItemToCells(item interface{}) ([]string, error) {
 	t.logger.Debugf("convertItemToCells: Converting item of type %T", item)
 
-	// 1. User-defined table-wide stringer (t.stringer) takes highest precedence.
+	// User-defined table-wide stringer (t.stringer) takes highest precedence.
 	if t.stringer != nil {
 		res, err := t.convertToStringer(item)
 		if err == nil {
@@ -1234,21 +1234,21 @@ func (t *Table) convertItemToCells(item interface{}) ([]string, error) {
 		t.logger.Warnf("convertItemToCells: Custom table stringer was set but incompatible for type %T: %v. Will attempt other methods.", item, err)
 	}
 
-	// 2. Handle untyped nil directly.
+	// Handle untyped nil directly.
 	if item == nil {
 		t.logger.Debugf("convertItemToCells: Item is untyped nil. Returning single empty cell.")
 		return []string{""}, nil
 	}
 
-	// 3. Use the new unified struct parser. It handles pointers and embedding.
+	// Use the new unified struct parser. It handles pointers and embedding.
 	// We only care about the values it returns.
 	_, values := t.extractFieldsAndValuesFromStruct(item)
 	if values != nil {
 		t.logger.Debugf("convertItemToCells: Structs %T reflected into %d cells: %v", item, len(values), values)
 		return values, nil
 	}
 
-	// 4. Fallback for any other single item (e.g., basic types, or types that implement Stringer/Formatter).
+	// Fallback for any other single item (e.g., basic types, or types that implement Stringer/Formatter).
 	// This code path is now for non-struct types.
 	if formatter, ok := item.(tw.Formatter); ok {
 		t.logger.Debugf("convertItemToCells: Item (non-struct, type %T) is tw.Formatter. Using Format().", item)