Merge pull request #114 from AbhinavRobinson/master

enum to string fix

Author: onesine

src/components/Input.tsx

@@ -4,7 +4,6 @@ import React, { useCallback, useContext, useEffect, useRef } from "react";
 import { BORDER_COLOR, DATE_FORMAT, RING_COLOR } from "../constants";
 import DatepickerContext from "../contexts/DatepickerContext";
 import { dateIsValid } from "../helpers";
-import { PopoverDirectionType } from "../types";
 
 import ToggleButton from "./ToggleButton";
 
@@ -200,8 +199,8 @@ const Input: React.FC<Props> = (e: Props) => {
                 div.classList.add("block");
 
                 // window.innerWidth === 767
-                const popoverOnUp = popoverDirection == PopoverDirectionType.up;
-                const popoverOnDown = popoverDirection === PopoverDirectionType.down;
+                const popoverOnUp = popoverDirection == "up";
+                const popoverOnDown = popoverDirection === "down";
                 if (
                     popoverOnUp ||
                     (window.innerWidth > 767 &&

src/components/Shortcuts.tsx

@@ -97,6 +97,7 @@ const Shortcuts: React.FC = () => {
                 if (Object.keys(DEFAULT_SHORTCUTS).includes(item)) {
                     return [item, DEFAULT_SHORTCUTS[item]];
                 } else {
+                    // using | makes this fail in typecheck as [string] is no longer recognised?
                     if (configs.shortcuts && configs?.shortcuts[item]) {
                         const customConfig = configs?.shortcuts[item];
                         const text = customConfig?.text;

src/types/index.ts

@@ -44,10 +44,7 @@ export type ClassNamesTypeProp = {
     footer?: (p?: object | null | undefined) => string | undefined;
 };
 
-export enum PopoverDirectionType {
-    up = "up",
-    down = "down"
-}
+export type PopoverDirectionType = "up" | "down";
 
 export interface DatepickerType {
     primaryColor?: string;