Fix DID commit resolve, set default drive description

Author: joepio

.claude/settings.local.json

@@ -24,7 +24,20 @@
       "Bash(npx tsc:*)",
       "mcp__charlotte__charlotte_screenshot",
       "Bash(npx vitest:*)",
-      "mcp__charlotte__charlotte_navigate"
+      "mcp__charlotte__charlotte_navigate",
+      "Bash(npx playwright:*)",
+      "Bash(npm run:*)",
+      "Bash(xargs grep:*)",
+      "Bash(find /Users/joep/dev/github/atomicdata-dev/atomic-server/browser/data-browser/src/components/Dialog -name *.ts -o -name *.tsx)",
+      "mcp__charlotte__charlotte_tab_open",
+      "mcp__charlotte__charlotte_click",
+      "mcp__charlotte__charlotte_find",
+      "Bash(pnpm exec:*)",
+      "Bash(curl -s http://localhost:9883)",
+      "Bash(curl -s http://localhost:5173)",
+      "mcp__charlotte__charlotte_tools",
+      "mcp__charlotte__charlotte_observe",
+      "mcp__charlotte__charlotte_type"
     ]
   }
 }

browser/data-browser/src/chunks/TablePage/EditorCells/SelectCell.tsx

@@ -150,7 +150,7 @@ function SelectCellEdit({
           <Content onKeyDown={handleKeyDown}>
             <SearchInputWrapper>
               <InputStyled
-                placeholder='Filter tags...'
+                placeholder='filter tags'
                 onChange={handleSearch}
                 ref={inputRef}
               />

browser/data-browser/src/chunks/TablePage/PropertyForm/EditPropertyDialog.tsx

@@ -31,7 +31,7 @@ export function EditPropertyDialog({
     resource.save();
   }, [resource]);
 
-  const [dialogProps, show, hide] = useDialog({ bindShow, onSuccess });
+  const [dialogProps, show, hide, visible] = useDialog({ bindShow, onSuccess });
 
   useEffect(() => {
     if (showDialog) {
@@ -52,12 +52,14 @@ export function EditPropertyDialog({
           <h1>Edit Column</h1>
         </DialogTitle>
         <DialogContent>
-          <PropertyForm
-            existingProperty
-            resource={resource}
-            category={category}
-            onSubmit={handleSaveClick}
-          />
+          {visible && (
+            <PropertyForm
+              existingProperty
+              resource={resource}
+              category={category}
+              onSubmit={handleSaveClick}
+            />
+          )}
         </DialogContent>
         <DialogActions>
           <Button onClick={handleSaveClick} disabled={!valid}>

browser/data-browser/src/chunks/TablePage/PropertyForm/NewPropertyDialog.tsx

@@ -9,10 +9,20 @@ import {
   useArray,
   useStore,
 } from '@tomic/react';
-import { useCallback, useEffect, type JSX } from 'react';
+import { useCallback, useEffect, useState, type JSX } from 'react';
 import { stringToSlug } from '@helpers/stringToSlug';
 import { PropertyFormCategory } from './categories';
 import { sortSubjectList } from '@views/OntologyPage/sortSubjectList';
+import {
+  Dialog,
+  DialogActions,
+  DialogContent,
+  DialogTitle,
+  useDialog,
+} from '@components/Dialog';
+import { Button } from '@components/Button';
+import { FormValidationContextProvider } from '@components/forms/formValidation/FormValidationContextProvider';
+import { PropertyForm } from './PropertyForm';
 
 interface NewPropertyDialogProps {
   showDialog: boolean;
@@ -70,12 +80,13 @@ export function NewPropertyDialog({
   bindShow,
 }: NewPropertyDialogProps): JSX.Element {
   const store = useStore();
+  const [propertyResource, setPropertyResource] = useState<Resource | null>(null);
+  const [valid, setValid] = useState(true);
+
   const [_properties, _setProperties, pushProp] = useArray(
     tableClassResource,
     core.properties.recommends,
-    {
-      commit: true,
-    },
+    { commit: true },
   );
 
   const savePropertyToTable = useCallback(
@@ -103,10 +114,21 @@ export function NewPropertyDialog({
     [store, tableClassResource, pushProp],
   );
 
+  const onSuccess = useCallback(async () => {
+    if (propertyResource) {
+      await savePropertyToTable(propertyResource);
+    }
+  }, [propertyResource, savePropertyToTable]);
+
+  const [dialogProps, show, hide] = useDialog({ bindShow, onSuccess });
+
   useEffect(() => {
-    if (!showDialog) return;
+    if (!showDialog) {
+      setPropertyResource(null);
+      return;
+    }
 
-    const create = async () => {
+    const init = async () => {
       // Determine the correct parent before signing the genesis commit, since
       // the parent is baked into the commit and controls authorization.
       const tableClassParent = await store.getResource(
@@ -121,7 +143,7 @@ export function NewPropertyDialog({
         selectedCategory as PropertyFormCategory,
       );
 
-      const propertyResource = await store.newResource({
+      const resource = await store.newResource({
         parent: parentSubject,
         isA,
         propVals: {
@@ -131,12 +153,47 @@ export function NewPropertyDialog({
           ...propVals,
         },
       });
-      await savePropertyToTable(propertyResource);
-      bindShow(false);
+
+      setPropertyResource(resource);
+      // show() is called in a separate effect after propertyResource is set,
+      // so the Dialog is already in the DOM when show() runs.
     };
 
-    create().catch(console.error);
+    init().catch(console.error);
   }, [showDialog]);
 
-  return <></>;
+  // Open dialog after propertyResource is set and Dialog is mounted.
+  useEffect(() => {
+    if (propertyResource && showDialog) {
+      show();
+    }
+  }, [propertyResource]);
+
+  const handleCreateClick = useCallback(() => {
+    hide(true);
+  }, [hide]);
+
+  return (
+    <FormValidationContextProvider onValidationChange={setValid}>
+      <Dialog {...dialogProps}>
+        <DialogTitle>
+          <h1>New {selectedCategory ? selectedCategory[0].toUpperCase() + selectedCategory.slice(1) : ''} Column</h1>
+        </DialogTitle>
+        <DialogContent>
+          {propertyResource && (
+            <PropertyForm
+              resource={propertyResource}
+              category={selectedCategory as PropertyFormCategory}
+              onSubmit={handleCreateClick}
+            />
+          )}
+        </DialogContent>
+        <DialogActions>
+          <Button onClick={handleCreateClick} disabled={!valid}>
+            Create
+          </Button>
+        </DialogActions>
+      </Dialog>
+    </FormValidationContextProvider>
+  );
 }

browser/data-browser/src/components/NewIdentitySection.tsx

@@ -58,6 +58,7 @@ export function NewIdentitySection({
         noParent: true,
         propVals: {
           [core.properties.name]: driveName,
+          [core.properties.description]: '# Welcome to your Drive\n\nThis is your personal Atomic Data drive. Edit this description to tell visitors what this space is about.',
           [core.properties.write]: [agentDID],
           [core.properties.read]: [agentDID],
         },

browser/data-browser/src/components/Tag/CreateTagRow.tsx

@@ -21,10 +21,12 @@ export function CreateTagRow({ parent, onNewTag }: CreateTagRowProps) {
   const [resetKey, setResetKey] = useState<number>(0);
 
   const createNewTag = useCallback(async () => {
-    const subject = await store.buildUniqueSubjectFromParts(
-      ['tag', tagName],
-      parent,
-    );
+    // When the parent is a DID, subjects are derived from the genesis commit
+    // signature and must not have a path appended. Only pre-compute a path-based
+    // subject for HTTP parents.
+    const subject = parent.startsWith('did:')
+      ? undefined
+      : await store.buildUniqueSubjectFromParts(['tag', tagName], parent);
 
     const tag = await store.newResource({
       subject,

browser/data-browser/src/helpers/navigation.tsx

@@ -24,7 +24,14 @@ export function constructOpenURL(
     return '#';
   }
 
-  const url = new URL(subject);
+  let url: URL;
+
+  try {
+    url = new URL(subject);
+  } catch {
+    // Non-URL subjects (e.g. DIDs) are always treated as remote resources
+    return constructURL(paths.show, { subject, ...extraParams });
+  }
 
   if (isRemoteResource(url)) {
     return constructURL(paths.show, { subject, ...extraParams });

browser/data-browser/src/hooks/useDevDrive.ts

@@ -36,6 +36,7 @@ export function useDevDrive() {
         noParent: true,
         propVals: {
           [core.properties.name]: 'dev',
+          [core.properties.description]: '# Welcome to your Drive\n\nThis is your personal Atomic Data drive. Edit this description to tell visitors what this space is about.',
           [core.properties.write]: [agentDID],
           [core.properties.read]: [agentDID],
         },

browser/data-browser/src/locales/de.po

@@ -116,6 +116,7 @@ msgstr "Einladungstext (optional)"
 msgid "Limit Usages (optional)"
 msgstr "Nutzungen beschränken (optional)"
 
+#: src/chunks/TablePage/PropertyForm/NewPropertyDialog.tsx
 #: src/components/InviteForm.tsx
 #: src/components/forms/NewForm/CustomCreateActions/CustomForms/NewArticleDialog.tsx
 #: src/components/forms/NewForm/CustomCreateActions/CustomForms/NewDriveDialog.tsx
@@ -2631,9 +2632,8 @@ msgstr "Öffne Bearbeitungsdialog"
 msgid "Add resource"
 msgstr "Ressource hinzufügen"
 
-#: src/chunks/TablePage/EditorCells/SelectCell.tsx
-msgid "Filter tags..."
-msgstr "Filtere Tags..."
+#~ msgid "Filter tags..."
+#~ msgstr "Filtere Tags..."
 
 #: src/views/OntologyPage/Property/PropertyCardRead.tsx
 msgid "Allows only:"
@@ -3753,3 +3753,8 @@ msgstr ""
 #: src/components/SideBar/AppMenu.tsx
 msgid "Create a fresh agent + drive on localhost:9883"
 msgstr ""
+
+#. placeholder {0}: selectedCategory ? selectedCategory[0].toUpperCase() + selectedCategory.slice(1) : ''
+#: src/chunks/TablePage/PropertyForm/NewPropertyDialog.tsx
+msgid "New {0} Column"
+msgstr ""

browser/data-browser/src/locales/en.po

@@ -661,6 +661,7 @@ msgstr "Name"
 msgid "Cancel"
 msgstr "Cancel"
 
+#: src/chunks/TablePage/PropertyForm/NewPropertyDialog.tsx
 #: src/components/InviteForm.tsx
 #: src/components/forms/NewForm/CustomCreateActions/CustomForms/NewArticleDialog.tsx
 #: src/components/forms/NewForm/CustomCreateActions/CustomForms/NewDriveDialog.tsx
@@ -2373,9 +2374,8 @@ msgstr "No Type selected"
 msgid "Add resource"
 msgstr "Add resource"
 
-#: src/chunks/TablePage/EditorCells/SelectCell.tsx
-msgid "Filter tags..."
-msgstr "Filter tags..."
+#~ msgid "Filter tags..."
+#~ msgstr "Filter tags..."
 
 #: src/components/ParentPicker/ParentPicker.tsx
 msgid "Enter a subject"
@@ -3784,3 +3784,8 @@ msgstr "Setting up dev drive..."
 #: src/components/SideBar/AppMenu.tsx
 msgid "Create a fresh agent + drive on localhost:9883"
 msgstr "Create a fresh agent + drive on localhost:9883"
+
+#. placeholder {0}: selectedCategory ? selectedCategory[0].toUpperCase() + selectedCategory.slice(1) : ''
+#: src/chunks/TablePage/PropertyForm/NewPropertyDialog.tsx
+msgid "New {0} Column"
+msgstr "New {0} Column"