Persist LORO snapshots in redb, get rid of localstorage for commits, fix

chatroom

Author: joepio

.claude/settings.local.json

@@ -61,7 +61,8 @@
       "Bash(export PATH=\"/opt/homebrew/bin:$PATH\")",
       "mcp__charlotte__charlotte_click_at",
       "Bash(curl -s -o /dev/null -w \"%{http_code}\" http://localhost:5173/)",
-      "Bash(node -e ':*)"
+      "Bash(node -e ':*)",
+      "Bash(pnpm build:wasm)"
     ]
   }
 }

browser/data-browser/public/wasm/client-db-worker.js

@@ -67,6 +67,23 @@ async function handleMessage(msg) {
       await db.populate();
       return;
 
+    case 'exportAllResources':
+      await ensureInit();
+      return db.exportAllResources();
+
+    case 'importAllResources':
+      await ensureInit();
+      return db.importAllResources(msg.jsonArray);
+
+    case 'putLoroSnapshot':
+      await ensureInit();
+      db.putLoroSnapshot(msg.subject, msg.data);
+      return;
+
+    case 'getLoroSnapshot':
+      await ensureInit();
+      return db.getLoroSnapshot(msg.subject);
+
     default:
       throw new Error(`Unknown message type: ${msg.type}`);
   }

browser/data-browser/src/helpers/initClientDb.ts

@@ -2,26 +2,13 @@ import { ClientDbWorker, type Store } from '@tomic/lib';
 
 // Track the current worker so we can terminate it on HMR reload.
 let currentWorker: ClientDbWorker | undefined;
-let offlineRestored = false;
 
 /**
  * Initialize the WASM ClientDb in a Web Worker and attach it to the Store.
  * Uses OPFS for persistent storage — data survives page reloads.
  * Falls back to in-memory if OPFS is unavailable.
  */
 export function initClientDb(store: Store): void {
-  // Restore offline-saved resources from localStorage FIRST (synchronous).
-  // These contain Loro snapshots that the WASM DB can't store.
-  // Only run once — HMR re-runs must not overwrite in-memory state.
-  if (!offlineRestored) {
-    offlineRestored = true;
-    const count = store.restoreOfflineResources();
-
-    if (count > 0) {
-      console.info(`[Offline] Restored ${count} resources from localStorage`);
-    }
-  }
-
   if (typeof Worker === 'undefined') return;
 
   // Terminate previous worker (important for Vite HMR — releases OPFS lock).
@@ -98,17 +85,6 @@ export function initClientDb(store: Store): void {
     console.info(
       `[ClientDb] WASM database ready, seeded ${properties.length} properties + ${otherPromises.length} resources`,
     );
-
-    // Debug: check if any loroUpdate was lost during seeding
-    for (const key of Object.keys(localStorage)) {
-      if (!key.startsWith('atomic.offline.')) continue;
-      const subject = key.slice('atomic.offline.'.length);
-      const resource = store.resources.get(subject);
-
-      if (resource && !resource.get('https://atomicdata.dev/properties/loroUpdate')) {
-        console.error(`[ClientDb] loroUpdate LOST after seeding for ${subject.slice(0, 40)}`);
-      }
-    }
   });
 
   // Tell the clientDb to wait for seeding before reporting as ready.

browser/data-browser/src/locales/de.po

@@ -653,7 +653,6 @@ msgstr "Nachrichtentext kopieren"
 #: src/chunks/TablePage/PropertyForm/NumberPropertyForm.tsx
 #: src/views/BookmarkPage/BookmarkPreview.tsx
 #: src/views/ChatRoomPage.tsx
-#: src/views/ChatRoomPage.tsx
 msgid "loading..."
 msgstr "Laden..."
 
@@ -4059,12 +4058,10 @@ msgstr ""
 msgid "Open tag page"
 msgstr ""
 
-#: src/views/ChatRoomPage.tsx
 #: src/views/ChatRoomPage.tsx
 msgid "No messages yet"
 msgstr ""
 
-#: src/views/ChatRoomPage.tsx
 #: src/views/ChatRoomPage.tsx
 msgid "Be the first to say something"
 msgstr ""

browser/data-browser/src/locales/es.po

@@ -664,7 +664,6 @@ msgstr "Copiar texto del mensaje"
 #: src/chunks/TablePage/PropertyForm/NumberPropertyForm.tsx
 #: src/views/BookmarkPage/BookmarkPreview.tsx
 #: src/views/ChatRoomPage.tsx
-#: src/views/ChatRoomPage.tsx
 msgid "loading..."
 msgstr "cargando..."
 
@@ -4045,12 +4044,10 @@ msgstr ""
 msgid "Open tag page"
 msgstr ""
 
-#: src/views/ChatRoomPage.tsx
 #: src/views/ChatRoomPage.tsx
 msgid "No messages yet"
 msgstr ""
 
-#: src/views/ChatRoomPage.tsx
 #: src/views/ChatRoomPage.tsx
 msgid "Be the first to say something"
 msgstr ""

browser/data-browser/src/locales/fr.po

@@ -677,7 +677,6 @@ msgstr "Copier le texte du message"
 #: src/chunks/TablePage/PropertyForm/NumberPropertyForm.tsx
 #: src/views/BookmarkPage/BookmarkPreview.tsx
 #: src/views/ChatRoomPage.tsx
-#: src/views/ChatRoomPage.tsx
 msgid "loading..."
 msgstr "chargement..."
 
@@ -4055,12 +4054,10 @@ msgstr ""
 msgid "Open tag page"
 msgstr ""
 
-#: src/views/ChatRoomPage.tsx
 #: src/views/ChatRoomPage.tsx
 msgid "No messages yet"
 msgstr ""
 
-#: src/views/ChatRoomPage.tsx
 #: src/views/ChatRoomPage.tsx
 msgid "Be the first to say something"
 msgstr ""

browser/lib/src/client-db.ts

@@ -163,6 +163,18 @@ export class ClientDbWorker {
     return result as number;
   }
 
+  /** Store a Loro CRDT snapshot for a resource subject. */
+  async putLoroSnapshot(subject: string, data: Uint8Array): Promise<void> {
+    await this.send({ type: 'putLoroSnapshot', subject, data });
+  }
+
+  /** Retrieve a Loro CRDT snapshot for a resource subject. Returns null if not found. */
+  async getLoroSnapshot(subject: string): Promise<Uint8Array | null> {
+    const result = await this.send({ type: 'getLoroSnapshot', subject });
+
+    return (result as Uint8Array | null) ?? null;
+  }
+
   /** Whether the worker has been initialized and seeded. */
   get isReady(): boolean {
     return this.ready && this.seeded;

browser/lib/src/client-db.worker.ts

@@ -33,7 +33,9 @@ export type WorkerRequest =
   | { id: number; type: 'allSubjects' }
   | { id: number; type: 'populate' }
   | { id: number; type: 'exportAllResources' }
-  | { id: number; type: 'importAllResources'; jsonArray: string };
+  | { id: number; type: 'importAllResources'; jsonArray: string }
+  | { id: number; type: 'putLoroSnapshot'; subject: string; data: Uint8Array }
+  | { id: number; type: 'getLoroSnapshot'; subject: string };
 
 /** Message types sent from worker back to main thread */
 export type WorkerResponse =
@@ -122,6 +124,19 @@ async function handleMessage(msg: WorkerRequest): Promise<unknown> {
       return db!.importAllResources(msg.jsonArray);
     }
 
+    case 'putLoroSnapshot': {
+      await ensureInit();
+      db!.putLoroSnapshot(msg.subject, msg.data);
+
+      return;
+    }
+
+    case 'getLoroSnapshot': {
+      await ensureInit();
+
+      return db!.getLoroSnapshot(msg.subject);
+    }
+
     default:
       throw new Error(`Unknown message type: ${(msg as WorkerRequest).type}`);
   }

browser/lib/src/commit.ts

@@ -330,7 +330,7 @@ const serializeMap = {
 };
 
 /** Replaces the keys of a Commit object with their respective json-ad key */
-function commitToJsonADObject(
+export function commitToJsonADObject(
   commit: UnsignedCommit | Commit,
   origin?: string,
 ): JSONADObject {

browser/lib/src/offline-persistence.test.ts

@@ -1,78 +1,23 @@
 import { describe, it, beforeEach } from 'vitest';
 import { Agent, Store, core, commits, JSCryptoProvider } from './index.js';
 
-/** Creates a fresh Store with the given agent, restoring any offline data. */
+/** Creates a fresh Store with the given agent. */
 function freshStore(agent: Agent): Store {
   const store = new Store({ serverUrl: 'https://example.com' });
   store.setAgent(agent);
-  store.restoreOfflineResources();
 
   return store;
 }
 
-describe('Offline persistence across reloads', () => {
+describe('Offline persistence', () => {
   let agent: Agent;
 
   beforeEach(async () => {
-    localStorage.clear();
     const keys = await Agent.generateKeyPair();
     const provider = new JSCryptoProvider(keys.privateKey);
     agent = new Agent(provider, `did:ad:agent:${keys.publicKey}`);
   });
 
-  it('resource subject stays the same after reload + re-edit', async ({
-    expect,
-  }) => {
-    // Session 1: create drive + doc, save offline
-    const store1 = freshStore(agent);
-    const drive = await store1.createDrive('Test Drive');
-    expect(drive.get(core.properties.write)).toContain(agent.subject);
-
-    const doc = await store1.newResource({
-      parent: drive.subject,
-      propVals: { [core.properties.name]: 'My Doc' },
-    });
-    await doc.save();
-    const subject = doc.subject;
-    expect(subject).toMatch(/^did:ad:/);
-
-    // Session 2: reload, edit, save
-    const store2 = freshStore(agent);
-    const doc2 = store2.getResourceLoading(subject);
-    expect(doc2.get(core.properties.name)).toBe('My Doc');
-
-    await doc2.set(core.properties.name, 'Updated', false);
-    await doc2.save();
-    expect(doc2.subject).toBe(subject);
-
-    // Session 3: reload, verify latest edit persisted
-    const store3 = freshStore(agent);
-    const doc3 = store3.getResourceLoading(subject);
-    expect(doc3.get(core.properties.name)).toBe('Updated');
-  });
-
-  it('multiple edits across reloads all persist', async ({ expect }) => {
-    const store1 = freshStore(agent);
-    const res = await store1.newResource({
-      noParent: true,
-      propVals: { [core.properties.name]: 'v1' },
-    });
-    await res.save();
-    const subject = res.subject;
-
-    for (const version of ['v2', 'v3', 'v4']) {
-      const store = freshStore(agent);
-      const r = store.getResourceLoading(subject);
-      await r.set(core.properties.name, version, false);
-      await r.save();
-      expect(r.subject).toBe(subject);
-    }
-
-    const storeFinal = freshStore(agent);
-    const rFinal = storeFinal.getResourceLoading(subject);
-    expect(rFinal.get(core.properties.name)).toBe('v4');
-  });
-
   it('offline save sets createdAt for sorting', async ({ expect }) => {
     const store = freshStore(agent);
     const drive = await store.createDrive('Timestamp Test');