Skip to content

[Pending] Merge Translation and CodeTrans examples #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from

Conversation

letonghan
Copy link
Collaborator

Description

Refactor Translation example and merge with CodeTrans.
Update python files, READMEs, docker compose files and k8s files.
The endpoint of megaservice is unified to /v1/translation, and add an additional parameter translation_type for different llm prompt.

Issues

#1240

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

None

Tests

Describe the tests that you ran to verify your changes.

…compose of rocm and xeon part

Signed-off-by: letonghan <[email protected]>
Copy link

github-actions bot commented Mar 17, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

@letonghan letonghan added the WIP label Mar 17, 2025
@letonghan letonghan closed this Mar 18, 2025
@letonghan letonghan reopened this Mar 18, 2025
Copy link
Collaborator

@lianhao lianhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still have codetrans e2e example after this merge? Or the codetrans e2e will be gone?


```
export HFTOKEN="insert-your-huggingface-token-here"
helm install codetrans oci://ghcr.io/opea-project/charts/codetrans --set global.HUGGINGFACEHUB_API_TOKEN=${HFTOKEN} -f gaudi-values.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only works with codetrans, won't work with translation. We need to create a new helm chart for translation after this PR is merged. I would suggest keep the helm chart part empty here.

Copy link
Collaborator Author

@letonghan letonghan Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like we should leave this part empty, and the helm chart of these two examples should be merged into one

@letonghan
Copy link
Collaborator Author

Do we still have codetrans e2e example after this merge? Or the codetrans e2e will be gone?

The CodeTrans example will be removed, and only the Translation example exists in GenAIExample.

@letonghan
Copy link
Collaborator Author

letonghan commented Mar 21, 2025

Frontend test failed because of endpoint parameters change. wenjiao helps to fix this issue in #1703
Will rerun this PR when #1703 is merged.

@joshuayao joshuayao linked an issue Mar 24, 2025 that may be closed by this pull request
@joshuayao joshuayao modified the milestone: v1.3 Mar 24, 2025
@joshuayao joshuayao self-requested a review March 24, 2025 02:28
Copy link
Collaborator

@joshuayao joshuayao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off on merging this PR to v1.3 for now.

@letonghan letonghan changed the title [WIP] Merge Translation and CodeTrans examples [Pending] Merge Translation and CodeTrans examples Mar 25, 2025
@letonghan letonghan removed the WIP label Mar 25, 2025
@CICD-at-OPEA
Copy link
Collaborator

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@CICD-at-OPEA
Copy link
Collaborator

This PR was closed because it has been stalled for 7 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Merge Translation Examples
5 participants