Skip to content

Refactor Translation Example #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 25, 2024
Merged

Refactor Translation Example #287

merged 21 commits into from
Jun 25, 2024

Conversation

zehao-intel
Copy link
Collaborator

@zehao-intel zehao-intel commented Jun 13, 2024

Description

Refactor Translation example to the new structure

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

n/a

Tests

n/a

Signed-off-by: zehao-intel <[email protected]>
Copy link
Collaborator

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move "Translation" from not supported case line to the upper case line in this file: .github/workflows/scripts/build_push.sh. The manifest e2e test will pass. Thank you.

@zehao-intel
Copy link
Collaborator Author

Please move "Translation" from not supported case line to the upper case line in this file: .github/workflows/scripts/build_push.sh. The manifest e2e test will pass. Thank you.

Hi, @daisy-ycguo . Thanks for reminding me. I have made the modification now.
Besides, I notice that "SearchQnA" is both in the not-supported-case line and the upper-case line. Do you know if it is expected?

@daisy-ycguo
Copy link
Collaborator

Please move "Translation" from not supported case line to the upper case line in this file: .github/workflows/scripts/build_push.sh. The manifest e2e test will pass. Thank you.

Hi, @daisy-ycguo . Thanks for reminding me. I have made the modification now. Besides, I notice that "SearchQnA" is both in the not-supported-case line and the upper-case line. Do you know if it is expected?

It is not expected. I might miss this workload. Please help to add it to the right line. Thank you.

@zehao-intel
Copy link
Collaborator Author

Please move "Translation" from not supported case line to the upper case line in this file: .github/workflows/scripts/build_push.sh. The manifest e2e test will pass. Thank you.

Hi, @daisy-ycguo . Thanks for reminding me. I have made the modification now. Besides, I notice that "SearchQnA" is both in the not-supported-case line and the upper-case line. Do you know if it is expected?

It is not expected. I might miss this workload. Please help to add it to the right line. Thank you.

Sure, do you want me to remove it from the not-supported-case line or the upper-case line?

Signed-off-by: zehao-intel <[email protected]>

Signed-off-by: zehao-intel <[email protected]>

Signed-off-by: zehao-intel <[email protected]>

Signed-off-by: zehao-intel <[email protected]>
@chensuyue chensuyue force-pushed the zehao/translation branch from 2c36250 to 34b2469 Compare June 20, 2024 02:40
Signed-off-by: zehao-intel <[email protected]>
Signed-off-by: zehao-intel <[email protected]>
Signed-off-by: zehao-intel <[email protected]>
@zehao-intel zehao-intel requested a review from WenjiaoYue June 25, 2024 02:04
…e. (#317)

* Add image build job in docker compose e2e gaudi test in CI (#305)

Signed-off-by: Yingchun Guo <[email protected]>

* Add gpu support for ChatQnA (#308)

* add gpu support for chatqna

Signed-off-by: Ding, Ke <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Ding, Ke <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Update ChatQnA for Xeon docker_compose.yaml to fix downloads failing (#310)

* Update docker_compose

* Updated docker_compose

* Updated docker_compose

* Add build docker image option for test scripts (#312)

Signed-off-by: chensuyue <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Yingchun Guo <[email protected]>
Signed-off-by: Ding, Ke <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: WenjiaoYue <[email protected]>
Co-authored-by: Ying Chun Guo <[email protected]>
Co-authored-by: Ke Ding <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Steve Fowler <[email protected]>
Co-authored-by: chen, suyue <[email protected]>
@zehao-intel zehao-intel merged commit 409c723 into main Jun 25, 2024
15 checks passed
@zehao-intel zehao-intel deleted the zehao/translation branch June 25, 2024 05:22
yogeshmpandey pushed a commit to hteeyeoh/GenAIExamples that referenced this pull request Aug 12, 2024
* Refactor Translation Example

Signed-off-by: zehao-intel <[email protected]>

* support e2s test

Signed-off-by: zehao-intel <[email protected]>

Signed-off-by: zehao-intel <[email protected]>

Signed-off-by: zehao-intel <[email protected]>

Signed-off-by: zehao-intel <[email protected]>

* fix test ip_address

Signed-off-by: zehao-intel <[email protected]>

* update test scripts

Signed-off-by: chensuyue <[email protected]>

* update test scripts

Signed-off-by: chensuyue <[email protected]>

* for test

Signed-off-by: chensuyue <[email protected]>

* fix readme and dockerfile

Signed-off-by: zehao-intel <[email protected]>

* revert test code

Signed-off-by: chensuyue <[email protected]>

* remove gaudi test update

Signed-off-by: chensuyue <[email protected]>

* bug fix

Signed-off-by: chensuyue <[email protected]>

* fix test xeon

Signed-off-by: zehao-intel <[email protected]>

* modify mega check

Signed-off-by: zehao-intel <[email protected]>

Signed-off-by: zehao-intel <[email protected]>

Signed-off-by: zehao-intel <[email protected]>

* fix ui

Signed-off-by: zehao-intel <[email protected]>

* fix ut network

Signed-off-by: zehao-intel <[email protected]>

* fix network

Signed-off-by: zehao-intel <[email protected]>

* Modify the corresponding format according to the backend new structure. (opea-project#317)

* Add image build job in docker compose e2e gaudi test in CI (opea-project#305)

Signed-off-by: Yingchun Guo <[email protected]>

* Add gpu support for ChatQnA (opea-project#308)

* add gpu support for chatqna

Signed-off-by: Ding, Ke <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Ding, Ke <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Update ChatQnA for Xeon docker_compose.yaml to fix downloads failing (opea-project#310)

* Update docker_compose

* Updated docker_compose

* Updated docker_compose

* Add build docker image option for test scripts (opea-project#312)

Signed-off-by: chensuyue <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Yingchun Guo <[email protected]>
Signed-off-by: Ding, Ke <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: WenjiaoYue <[email protected]>
Co-authored-by: Ying Chun Guo <[email protected]>
Co-authored-by: Ke Ding <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Steve Fowler <[email protected]>
Co-authored-by: chen, suyue <[email protected]>

---------

Signed-off-by: zehao-intel <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: Yingchun Guo <[email protected]>
Signed-off-by: Ding, Ke <[email protected]>
Signed-off-by: WenjiaoYue <[email protected]>
Co-authored-by: chen, suyue <[email protected]>
Co-authored-by: WenjiaoYue <[email protected]>
Co-authored-by: Ying Chun Guo <[email protected]>
Co-authored-by: Ke Ding <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Steve Fowler <[email protected]>
Co-authored-by: lvliang-intel <[email protected]>
JakubLedworowski pushed a commit to JakubLedworowski/GenAIExamples that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants