Add milvus support for data-prep #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongfengdu
requested review from
lianhao,
daisy-ycguo and
mkbhanda
as code owners
|
Will need to fix CI first #471 |
yongfengdu
force-pushed
the
milvus
branch
2 times, most recently
from
edb5289 to
307c7a2
Compare
mkbhanda
reviewed
Oct 16, 2024
mkbhanda
approved these changes
Oct 16, 2024
Use "helm install" with -f milvus-values.yaml Signed-off-by: Dolpher Du <[email protected]>
lianhao
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add milvus support for data-prep and retriever-usvc.
Use "helm install" with -f milvus-values.yaml
We don't provide milvus deployment helm chart, just reuse the one officially released with current version.
https://artifacthub.io/packages/helm/milvus/milvus
Description
The summary of the proposed changes as long as the relevant motivation and context.
Issues
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
helm install dataprep data-prep -f data-prep/milvus-values.yaml