-
Notifications
You must be signed in to change notification settings - Fork 21
refactor: Clean up project files by removing TargetFrameworks and formatting #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…matting Signed-off-by: André Silva <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR centralizes the TargetFrameworks property from individual project files into the shared Directory.Build.props file to ensure consistency across all projects in the solution. This refactoring eliminates duplication and simplifies framework management by defining the target frameworks once in a central location.
Key Changes:
- Moved
TargetFrameworksproperty from four individual.csprojfiles toDirectory.Build.props - Reformatted XML elements in project files for improved readability
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Directory.Build.props | Added centralized TargetFrameworks property and reformatted Import element |
| src/OpenFeature/OpenFeature.csproj | Removed TargetFrameworks property and reformatted PackageReference elements |
| src/OpenFeature.DependencyInjection/OpenFeature.DependencyInjection.csproj | Removed TargetFrameworks property |
| src/OpenFeature.Hosting/OpenFeature.Hosting.csproj | Removed TargetFrameworks property |
| src/OpenFeature.Providers.MultiProvider/OpenFeature.Providers.MultiProvider.csproj | Removed TargetFrameworks property |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
=======================================
Coverage 89.76% 89.76%
=======================================
Files 77 77
Lines 3166 3166
Branches 364 364
=======================================
Hits 2842 2842
Misses 253 253
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <[email protected]> Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva [email protected]
This PR
This pull request updates the target frameworks configuration for several projects to centralize and simplify framework management. The main change is moving the
TargetFrameworksproperty from individual project files to the sharedDirectory.Build.propsfile, ensuring consistency across all projects. Minor formatting improvements were also made for readability.Centralized Target Frameworks Configuration:
TargetFrameworksproperty from each individual.csprojfile (OpenFeature,OpenFeature.DependencyInjection,OpenFeature.Hosting, andOpenFeature.Providers.MultiProvider) to the sharedDirectory.Build.propsfile for unified management. [1] [2] [3] [4] [5]Formatting Improvements:
ImportandPackageReferenceelements inDirectory.Build.propsandOpenFeature/OpenFeature.csprojfor better readability and maintainability. [1] [2]Related Issues
Fixes #610