Skip to content

Conversation

@askpt
Copy link
Member

@askpt askpt commented Oct 27, 2025

Signed-off-by: André Silva [email protected]

This PR

This pull request updates the target frameworks configuration for several projects to centralize and simplify framework management. The main change is moving the TargetFrameworks property from individual project files to the shared Directory.Build.props file, ensuring consistency across all projects. Minor formatting improvements were also made for readability.

Centralized Target Frameworks Configuration:

  • Moved the TargetFrameworks property from each individual .csproj file (OpenFeature, OpenFeature.DependencyInjection, OpenFeature.Hosting, and OpenFeature.Providers.MultiProvider) to the shared Directory.Build.props file for unified management. [1] [2] [3] [4] [5]

Formatting Improvements:

  • Improved formatting of Import and PackageReference elements in Directory.Build.props and OpenFeature/OpenFeature.csproj for better readability and maintainability. [1] [2]

Related Issues

Fixes #610

@askpt askpt requested a review from Copilot October 27, 2025 15:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR centralizes the TargetFrameworks property from individual project files into the shared Directory.Build.props file to ensure consistency across all projects in the solution. This refactoring eliminates duplication and simplifies framework management by defining the target frameworks once in a central location.

Key Changes:

  • Moved TargetFrameworks property from four individual .csproj files to Directory.Build.props
  • Reformatted XML elements in project files for improved readability

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Directory.Build.props Added centralized TargetFrameworks property and reformatted Import element
src/OpenFeature/OpenFeature.csproj Removed TargetFrameworks property and reformatted PackageReference elements
src/OpenFeature.DependencyInjection/OpenFeature.DependencyInjection.csproj Removed TargetFrameworks property
src/OpenFeature.Hosting/OpenFeature.Hosting.csproj Removed TargetFrameworks property
src/OpenFeature.Providers.MultiProvider/OpenFeature.Providers.MultiProvider.csproj Removed TargetFrameworks property

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.76%. Comparing base (29e1657) to head (78bca2f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #611   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files          77       77           
  Lines        3166     3166           
  Branches      364      364           
=======================================
  Hits         2842     2842           
  Misses        253      253           
  Partials       71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Copilot <[email protected]>
Signed-off-by: André Silva <[email protected]>
@askpt askpt marked this pull request as ready for review October 27, 2025 15:20
@askpt askpt requested a review from a team as a code owner October 27, 2025 15:20
This was referenced Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Centralize TargetFrameworks definition via shared build.props

4 participants