fix: replace name with domain

Signed-off-by: William Kim <[email protected]>

Author: grepfruit19

README.md

@@ -53,9 +53,9 @@ OpenFeature::SDK.configure do |config|
 end
 
 # Create a client
-client = OpenFeature::SDK.build_client(name: "my-app")
+client = OpenFeature::SDK.build_client()
 # Create a client for a different domain, this will use the provider assigned to that domain
-legacy_flag_client = OpenFeature::SDK.build_client(name: "Legacy", domain: "legacy_flags")
+legacy_flag_client = OpenFeature::SDK.build_client(domain: "legacy_flags")
 
 # fetching boolean value feature flag
 bool_value = client.fetch_boolean_value(flag_key: 'boolean_flag', default_value: false)

lib/open_feature/sdk/api.rb

@@ -42,8 +42,8 @@ def configure(&block)
         block.call(configuration)
       end
 
-      def build_client(name: nil, version: nil, domain: nil)
-        client_options = Metadata.new(name: name, version: version, domain: domain).freeze
+      def build_client(version: nil, domain: nil)
+        client_options = Metadata.new(version: version, domain: domain).freeze
 
         active_provider = provider(domain:).nil? ? Provider::NoOpProvider.new : provider(domain:)
 

lib/open_feature/sdk/metadata.rb

@@ -20,18 +20,17 @@ module SDK
     #   metadata_two = Metadata.new(name: 'name-for-metadata')
     #   metadata_two == metadata # true - equality based on values
     class Metadata
-      attr_reader :name, :version, :domain
+      attr_reader :version, :domain
 
-      def initialize(name:, version: nil, domain: nil)
-        @name = name
+      def initialize(version: nil, domain: nil)
         @version = version
         @domain = domain
       end
 
       def ==(other)
         raise ArgumentError("Expected comparison to be between Metadata object") unless other.is_a?(Metadata)
 
-        @name == other.name && @version == other.version
+        @domain == other.domain && @version == other.version
       end
     end
   end

lib/open_feature/sdk/provider/in_memory_provider.rb

@@ -3,10 +3,8 @@ module SDK
     module Provider
       # TODO: Add evaluation context support
       class InMemoryProvider
-        NAME = "In-memory Provider"
-
         def initialize(flags = {})
-          @metadata = Metadata.new(name: NAME).freeze
+          @metadata = Metadata.new.freeze
           @flags = flags
         end
 

lib/open_feature/sdk/provider/no_op_provider.rb

@@ -26,12 +26,11 @@ module Provider
       #
       class NoOpProvider
         REASON_NO_OP = "No-op"
-        NAME = "No-op Provider"
 
         attr_reader :metadata
 
         def initialize
-          @metadata = Metadata.new(name: NAME).freeze
+          @metadata = Metadata.new.freeze
         end
 
         def fetch_boolean_value(flag_key:, default_value:, evaluation_context: nil)

spec/open_feature/sdk/api_spec.rb

@@ -43,10 +43,6 @@
     it do
       expect(api.provider.metadata).is_a?(OpenFeature::SDK::Metadata)
     end
-
-    it do
-      expect(api.provider.metadata).to eq(OpenFeature::SDK::Metadata.new(name: OpenFeature::SDK::Provider::NoOpProvider::NAME))
-    end
   end
 
   context "with Requirement 1.1.5" do
@@ -55,11 +51,11 @@
         config.set_provider(OpenFeature::SDK::Provider::NoOpProvider.new)
       end
 
-      api.build_client(name: "requirement-1.1.5")
+      api.build_client
     end
 
     it "provide a function for creating a client which accepts the following options: * name (optional): A logical string identifier for the client." do
-      expect(api).to respond_to(:build_client).with_keywords(:name, :version)
+      expect(api).to respond_to(:build_client).with_keywords(:version)
     end
 
     it do
@@ -76,11 +72,11 @@
       provider = OpenFeature::SDK::Provider::InMemoryProvider.new
 
       api.configure do |config|
-        config.set_provider(provider, domain: 'testing1')
+        config.set_provider(provider, domain: "testing1")
       end
 
-      client = api.build_client(name: "with-domain", domain: "testing1")
-      no_domain_client = api.build_client(name: "without-domain")
+      client = api.build_client(domain: "testing1")
+      no_domain_client = api.build_client
 
       expect(client.provider).to be(provider)
       expect(no_domain_client.provider).to be_an_instance_of(OpenFeature::SDK::Provider::NoOpProvider)
@@ -95,7 +91,7 @@
         config.set_provider(provider)
       end
 
-      no_domain_client = api.build_client(name: "without-domain")
+      no_domain_client = api.build_client
 
       expect(no_domain_client.provider).to be(provider)
     end
@@ -105,7 +101,7 @@
         config.set_provider(OpenFeature::SDK::Provider::InMemoryProvider.new)
       end
 
-      domain_client = api.build_client(name: "with-domain", domain: "testing2")
+      domain_client = api.build_client(domain: "testing2")
       # This domain was never given a provider, so it should default to the NoOpProvider
       expect(domain_client.provider).to be_an_instance_of(OpenFeature::SDK::Provider::NoOpProvider)
     end

spec/open_feature/sdk/client_spec.rb

@@ -7,8 +7,8 @@
 RSpec.describe OpenFeature::SDK::Client do
   subject(:client) { described_class.new(provider: provider, client_options: client_metadata) }
   let(:provider) { OpenFeature::SDK::Provider::NoOpProvider.new }
-  let(:client_metadata) { OpenFeature::SDK::Metadata.new(name: name) }
-  let(:name) { "my-openfeature-client" }
+  let(:client_metadata) { OpenFeature::SDK::Metadata.new(domain: domain) }
+  let(:domain) { "my-openfeature-client" }
 
   context "Requirement 1.2.1" do
     before do
@@ -24,10 +24,10 @@
   end
 
   context "Requirement 1.2.2" do
-    it "MUST define a metadata member or accessor, containing an immutable name field or accessor of type string, which corresponds to the name value supplied during client creation." do
+    it "MUST define a metadata member or accessor, containing an immutable domain field or accessor of type string, which corresponds to the domain value supplied during client creation." do
       expect(client).to respond_to(:metadata)
-      expect(client.metadata).to respond_to(:name)
-      expect(client.metadata.name).to eq(name)
+      expect(client.metadata).to respond_to(:domain)
+      expect(client.metadata.domain).to eq(domain)
     end
   end
 
@@ -195,14 +195,14 @@
 
           it do
             expect(client.fetch_object_details(flag_key: flag_key,
-              default_value: {name: "some-name"})).is_a?(OpenFeature::SDK::Provider::ResolutionDetails)
+              default_value: {domain: "some-domain"})).is_a?(OpenFeature::SDK::Provider::ResolutionDetails)
           end
         end
 
         context "Requirement 1.4.2" do
           it "The evaluation details structure's value field MUST contain the evaluated flag value" do
             expect(client.fetch_object_details(flag_key: flag_key,
-              default_value: {name: "some-name"}).value).is_a?(String)
+              default_value: {domain: "some-domain"}).value).is_a?(String)
           end
         end