Un-expose client provider, comment out corresponding tests

Signed-off-by: William Kim <[email protected]>

Author: grepfruit19

lib/open_feature/sdk/client.rb

@@ -8,7 +8,7 @@ class Client
       RESULT_TYPE = %i[boolean string number object].freeze
       SUFFIXES = %i[value details].freeze
 
-      attr_reader :metadata, :provider
+      attr_reader :metadata
 
       attr_accessor :hooks
 

spec/open_feature/sdk/api_spec.rb

@@ -71,43 +71,48 @@
     pending
   end
 
-  context "when domain is given" do
-    it "can generate a client both with and without that domain" do
-      provider = OpenFeature::SDK::Provider::InMemoryProvider.new
+  # TODO: These tests should be re-enabled when the client's provider is exposed via the metadata
+  # See this PR for context: https://github.com/open-feature/ruby-sdk/pull/109
 
-      api.configure do |config|
-        config.set_provider(provider, domain: "testing1")
-      end
+  # context "when domain is given" do
+  #   it "can generate a client both with and without that domain" do
+  #     provider = OpenFeature::SDK::Provider::InMemoryProvider.new
 
-      client = api.build_client(domain: "testing1")
-      no_domain_client = api.build_client
+  #     api.configure do |config|
+  #       config.set_provider(provider, domain: "testing1")
+  #     end
 
-      expect(client.provider).to be(provider)
-      expect(no_domain_client.provider).to be_an_instance_of(OpenFeature::SDK::Provider::NoOpProvider)
-    end
-  end
+  #     client = api.build_client(domain: "testing1")
+  #     no_domain_client = api.build_client
 
-  context "when domain is not provided" do
-    it "can generate a client without a domain properly" do
-      provider = OpenFeature::SDK::Provider::InMemoryProvider.new
+  #     expect(client.provider).to be(provider)
+  #     expect(no_domain_client.provider).to be_an_instance_of(OpenFeature::SDK::Provider::NoOpProvider)
+  #   end
+  # end
 
-      api.configure do |config|
-        config.set_provider(provider)
-      end
+  # context "when domain is not provided" do
+  #   it "can generate a client without a domain properly" do
+  #     provider = OpenFeature::SDK::Provider::InMemoryProvider.new
 
-      no_domain_client = api.build_client
+  #     api.configure do |config|
+  #       config.set_provider(provider)
+  #     end
 
-      expect(no_domain_client.provider).to be(provider)
-    end
+  #     no_domain_client = api.build_client
 
-    it "can generate a client with a domain properly" do
-      api.configure do |config|
-        config.set_provider(OpenFeature::SDK::Provider::InMemoryProvider.new)
-      end
+  #     expect(no_domain_client.provider).to be(provider)
+  #   end
 
-      domain_client = api.build_client(domain: "testing2")
-      # This domain was never given a provider, so it should default to the NoOpProvider
-      expect(domain_client.provider).to be_an_instance_of(OpenFeature::SDK::Provider::NoOpProvider)
-    end
-  end
+  #   it "can generate a client with a domain properly" do
+  #     api.configure do |config|
+  #       config.set_provider(OpenFeature::SDK::Provider::InMemoryProvider.new)
+  #     end
+
+  #     domain_client = api.build_client(domain: "testing2")
+  #     # This domain was never given a provider, so it should default to the NoOpProvider
+  #     expect(domain_client.provider).to be_an_instance_of(OpenFeature::SDK::Provider::NoOpProvider)
+  #   end
+  # end
+
+  # End Client provider metadata tests
 end