feat: Add evaluation context based on requirement 3.1.1 #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 99.40% 99.44% +0.03%
==========================================
Files 12 13 +1
Lines 168 180 +12
==========================================
+ Hits 167 179 +12
Misses 1 1 ☔ View full report in Codecov by Sentry. |
beeme1mr
reviewed
Apr 1, 2024
maxveldink
commented
Apr 1, 2024
Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
maxveldink
force-pushed
the
mv/evaluation-context-3.1.1
branch
from
309d4f7 to
5e5de79
Compare
beeme1mr
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
EvaluationContextwhich fulfills requirement 3.1. Note that this isn't used anywhere yet and I will continue to build it out by adding new spec requirements.Follow-up Tasks
Will continue implementing other parts of EC and use it in clients