Skip to content

Conversation

@maxveldink
Copy link
Contributor

This PR

  • Separates the Metadata class into ClientMetadata and ProviderMetadata structs that explicitly call out the required fields.
  • Adds tests demonstrating the client creation requirements are met from the spec
  • I noticed that we were still pulling in concurrent-ruby but no longer using it for the concurrent Array primitive. Removed that as well

Follow-up Tasks

Move on to testing client flag evaluation testing

@maxveldink maxveldink requested a review from a team as a code owner April 2, 2024 10:06
@codecov
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (f8e016f) to head (4f0cb23).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   99.44%   99.42%   -0.02%     
==========================================
  Files          13       14       +1     
  Lines         180      174       -6     
==========================================
- Hits          179      173       -6     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxveldink maxveldink merged commit f028c39 into main Apr 4, 2024
@maxveldink maxveldink deleted the mv/client-creation branch April 4, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants