feat: add hook hints #135
Merged
feat: add hook hints #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 99.48% 99.53% +0.04%
==========================================
Files 15 16 +1
Lines 196 214 +18
==========================================
+ Hits 195 213 +18
Misses 1 1 ☔ View full report in Codecov by Sentry. |
mschoenlaub
force-pushed
the
hook-hints
branch
3 times, most recently
from
5660c94 to
20cf539
Compare
beeme1mr
previously approved these changes
May 1, 2024
Signed-off-by: Manuel Schönlaub <[email protected]>
maxveldink
approved these changes
May 2, 2024
Contributor
maxveldink
left a comment
maxveldink
left a comment
There was a problem hiding this comment.
🦑 Cool, yea no issues as written for me. I think we'll want to standardize around this ALLOWED_* approach in other parts of the SDK, so I'm glad we're experimenting with it here.
beeme1mr
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
A first step towards fixing #52 .
Notes
Follow-up Tasks
Use this data structure in follow-up PRs to implement hooks.
How to test
N/A