Skip to content

Commit 57d0790

Browse files
committed
vader fix for 4937 (PPC wmb location)
I have some tests that failed on PPC with the recent vader changes. I'm suspicious of the set_header() function where there's a wmb() call that looks like it boils down to set some data set the header to indicate the data is available wmb and I think the wmb needs to go up a line. More details here: #4937 with a copy of the "maxsoak.c" testcase at https://gist.github.com/markalle/a1c203297cb6af22a3fb5c24e62b2ba3 Signed-off-by: Mark Allen <[email protected]>
1 parent ecbdf17 commit 57d0790

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

opal/mca/btl/vader/btl_vader_fbox.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ static inline void mca_btl_vader_fbox_set_header (mca_btl_vader_fbox_hdr_t *hdr,
5151
uint16_t seq, uint32_t size)
5252
{
5353
mca_btl_vader_fbox_hdr_t tmp = {.data = {.tag = tag, .seq = seq, .size = size}};
54-
hdr->ival = tmp.ival;
5554
opal_atomic_wmb ();
55+
hdr->ival = tmp.ival;
5656
}
5757

5858
/* attempt to reserve a contiguous segment from the remote ep */

0 commit comments

Comments
 (0)