Skip to content

Commit 295a580

Browse files
authored
Merge pull request #14 from oslabs-beta/dockerbash
Docker build&run succesfully
2 parents 1a6f624 + 84fdd9f commit 295a580

File tree

4 files changed

+13
-9
lines changed

4 files changed

+13
-9
lines changed

.env

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
APP_DEV=true
22
BROWSER=non
33
SKIP_PREFLIGHT_CHECK=true
4-
MONGO_LINK=mongodb://0.0.0.0:27017
4+
MONGO_LINK=mongodb://127.0.0.1:27017

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ COPY package.json .
2020

2121
# RUN npm run install-once
2222
# # RUN npm install
23-
# RUN rm -rf node_modules
23+
RUN rm -rf node_modules
2424
# remove node modules from the file and only leave dependencies to be installed later
2525
# RUN npm install -g npm@latest
2626
# USER node

docker-compose.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,14 @@ version: "3"
22

33
services:
44
app:
5-
image: spearmint:latest
6-
build: .
5+
image: spearmint
76
environment:
8-
- DISPLAY=0
9-
volumes:
10-
- /tmp/.X11-unix:/tmp/.X11-unix
11-
network_mode: host
7+
- DISPLAY= 172.17.0.1:0.0
8+
command: npm run docker
9+
# volumes:
10+
# - /tmp/.X11-unix:/tmp/.X11-unix
11+
# depends_on:
12+
# - mongo
13+
# mongo:
14+
# image: mongo:latest
15+
# container_name: mongodb

public/electron.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function createWindow() {
6969
// });
7070

7171
mainWindow.loadFile(path.join(__dirname, 'index.html')); // unsure why we need the path.join, but index.html not found without it
72-
mainWindow.webContents.openDevTools()
72+
// mainWindow.webContents.openDevTools()
7373
//////////////////////////////////////////////////
7474
//Creates terminal, specifies dimensions based on columns and rows
7575
//////////////////////////////////////////////////

0 commit comments

Comments
 (0)