Refactor unit tests (#851)

Author: utpilla

test/OpenTelemetry.Exporter.Geneva.Benchmark/Exporter/TraceExporterBenchmarks.cs

@@ -14,7 +14,6 @@
 // limitations under the License.
 // </copyright>
 
-using System;
 using System.Collections.Generic;
 using System.Diagnostics;
 using BenchmarkDotNet.Attributes;

test/OpenTelemetry.Exporter.Geneva.Tests/GenevaLogExporterTests.cs

@@ -24,6 +24,7 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 using System.Threading;
+using System.Threading.Tasks;
 using Microsoft.Extensions.Logging;
 using OpenTelemetry.Logs;
 using Xunit;

test/OpenTelemetry.Exporter.Geneva.Tests/GenevaTraceExporterTests.cs

@@ -24,6 +24,7 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 using System.Threading;
+using System.Threading.Tasks;
 using OpenTelemetry.Trace;
 using Xunit;
 

test/OpenTelemetry.Exporter.Stackdriver.Tests/OpenTelemetry.Exporter.Stackdriver.Tests.csproj

@@ -6,12 +6,6 @@
     <TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net462</TargetFrameworks>
   </PropertyGroup>
 
-  <ItemGroup>
-    <Content Include="xunit.runner.json">
-      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
-    </Content>
-  </ItemGroup>
-
   <ItemGroup>
     <ProjectReference Include="$(RepoRoot)\src\OpenTelemetry.Exporter.Stackdriver\OpenTelemetry.Exporter.Stackdriver.csproj" />
   </ItemGroup>

test/OpenTelemetry.Exporter.Stackdriver.Tests/xunit.runner.json

@@ -13,11 +13,9 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 // </copyright>
-using System;
 using System.Diagnostics;
 using System.Linq;
 using System.Text;
-using System.Threading;
 using System.Threading.Tasks;
 using Elasticsearch.Net;
 using Moq;

test/OpenTelemetry.Instrumentation.ElasticsearchClient.Tests/ElasticsearchClientTests.cs

@@ -133,7 +133,7 @@ public void ThreadingRelatedMetricsTest()
         List<Task> tasks = new List<Task>();
         for (int i = 0; i < taskCount; i++)
         {
-            tasks.Add(Task.Run(() => { Console.Write("Hi"); }));
+            tasks.Add(Task.Run(() => { }));
         }
 
         Task.WaitAll(tasks.ToArray());

test/OpenTelemetry.Instrumentation.Runtime.Tests/RuntimeMetricsTests.cs

@@ -53,7 +53,7 @@ public TelemetryClientMessageInspectorTests()
             }
             catch
             {
-                this.listener.Stop();
+                this.listener.Close();
                 this.listener = null;
                 retryCount--;
             }
@@ -128,7 +128,10 @@ async void Listener()
 
     public void Dispose()
     {
-        this.listener?.Stop();
+        if (this.listener != null)
+        {
+            (this.listener as IDisposable).Dispose();
+        }
     }
 
     [Theory]