[Resources.Process] Remove process.command

`process.command` isn't reliable with the different modes of executing modern .NET processes.

Author: martincostello

src/OpenTelemetry.Resources.Process/CHANGELOG.md

@@ -6,9 +6,8 @@
   ([#4080](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/4080))
 
 * Add new process resource attributes: `process.args_count`,
-  `process.command`, `process.creation.time`,
-  `process.executable.path`, `process.title` and
-  `process.working_directory`.
+  `process.creation.time`, `process.executable.path`,
+  `process.title` and `process.working_directory`.
   ([#4036](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/4036))
 
 ## 1.15.0-beta.1

src/OpenTelemetry.Resources.Process/ProcessDetector.cs

@@ -48,20 +48,9 @@ public Resource Detect()
         // See https://github.com/open-telemetry/semantic-conventions/blob/v1.40.0/docs/resource/process.md#selecting-process-attributes.
         var commandArgs = GetCommandLineArgs();
 
-        if (commandArgs.Length > 0)
+        if (commandArgs is not null)
         {
-#if NET
-            processPath ??= commandArgs[0];
-#else
-            processPath = commandArgs[0];
-#endif
-
-            attributes.Add(new(ProcessSemanticConventions.AttributeProcessCommand, commandArgs[0]));
-
-            // Do not count the executable path as an argument
-            int count = commandArgs.Length - 1;
-
-            attributes.Add(new(ProcessSemanticConventions.AttributeProcessArgsCount, count));
+            attributes.Add(new(ProcessSemanticConventions.AttributeProcessArgsCount, commandArgs.Length));
         }
 
         if (!string.IsNullOrEmpty(processPath))
@@ -71,15 +60,15 @@ public Resource Detect()
 
         return new Resource(attributes);
 
-        static string[] GetCommandLineArgs()
+        static string[]? GetCommandLineArgs()
         {
             try
             {
                 return Environment.GetCommandLineArgs();
             }
             catch (NotSupportedException)
             {
-                return [];
+                return null;
             }
         }
 

test/OpenTelemetry.Resources.Process.Tests/ProcessDetectorTests.cs

@@ -15,7 +15,6 @@ public void TestProcessAttributes()
         var resourceAttributes = resource.Attributes.ToDictionary(x => x.Key, x => x.Value);
 
         Assert.IsType<long>(resourceAttributes[ProcessSemanticConventions.AttributeProcessArgsCount]);
-        Assert.IsType<string>(resourceAttributes[ProcessSemanticConventions.AttributeProcessCommand]);
         Assert.IsType<string>(resourceAttributes[ProcessSemanticConventions.AttributeProcessCreationTime]);
         Assert.IsType<string>(resourceAttributes[ProcessSemanticConventions.AttributeProcessExecutablePath]);
         Assert.IsType<string>(resourceAttributes[ProcessSemanticConventions.AttributeProcessOwner]);