Skip to content

[StackExchange.Redis] ignore Enrich callback exceptions#4900

Open
matt-hensley wants to merge 1 commit into
open-telemetry:mainfrom
matt-hensley:enrich-errors
Open

[StackExchange.Redis] ignore Enrich callback exceptions#4900
matt-hensley wants to merge 1 commit into
open-telemetry:mainfrom
matt-hensley:enrich-errors

Conversation

@matt-hensley

@matt-hensley matt-hensley commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Changes

Ignore Enrich callback exceptions just like the existing Filter callback handling. Exceptions from the Enrich callback prevented the activity being constructed from being stopped appropriately.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions Bot added the comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis label Jul 24, 2026
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 24, 2026

Copy link
Copy Markdown

Pull request dashboard status

Status last refreshed: 2026-07-25 15:32:13 UTC.

  • Waiting on: Author
  • Next step: Address or respond to 1 review feedback item:
    • Top-level feedback: 1
    • For each item, reply to move the discussion forward, e.g. link to the commit that addresses it, explain why no change is needed, or ask a follow-up question.

This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. If you believe this pull request is incorrectly routed as waiting on the author, comment /dashboard route:reviewers to route it from waiting on the author to waiting on reviewers. If the last refreshed time above predates your latest reply or push, the dashboard hasn't processed it yet.

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.33%. Comparing base (9d4e55f) to head (4d3f20a).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4900   +/-   ##
=======================================
  Coverage   77.33%   77.33%           
=======================================
  Files         468      468           
  Lines       19811    19814    +3     
=======================================
+ Hits        15320    15323    +3     
  Misses       4491     4491           
Flag Coverage Δ
unittests-Instrumentation.StackExchangeRedis 94.41% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...mentation/RedisProfilerEntryToActivityConverter.cs 93.33% <100.00%> (+0.13%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matt-hensley
matt-hensley marked this pull request as ready for review July 24, 2026 21:39
@matt-hensley
matt-hensley requested a review from a team as a code owner July 24, 2026 21:39

@martincostello martincostello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a CHANGELOG entry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants