[repo] ProviderBuilderExtensions.Tests - AnalysisLevel latest-all (#6156)

Co-authored-by: Rajkumar Rangaraj <[email protected]>

Author: Kielek

.editorconfig

@@ -156,6 +156,10 @@ dotnet_diagnostic.IDE0005.severity = warning
 # RS0041: Public members should not use oblivious types
 dotnet_diagnostic.RS0041.severity = suggestion
 
+[*Tests.cs]
+# CA1515: Disable making types internal for Tests classes. It is required by xunit
+dotnet_diagnostic.CA1515.severity = none
+
 [**/obj/**.cs]
 generated_code = true
 

test/OpenTelemetry.Api.ProviderBuilderExtensions.Tests/Metrics/TestMeterProviderBuilder.cs

@@ -6,7 +6,7 @@
 
 namespace OpenTelemetry.Api.ProviderBuilderExtensions.Tests;
 
-public sealed class TestMeterProviderBuilder : MeterProviderBuilder, IMeterProviderBuilder, IDisposable
+internal sealed class TestMeterProviderBuilder : MeterProviderBuilder, IMeterProviderBuilder, IDisposable
 {
     public TestMeterProviderBuilder()
     {
@@ -17,9 +17,9 @@ public TestMeterProviderBuilder()
 
     public ServiceProvider? ServiceProvider { get; private set; }
 
-    public List<string> Meters { get; } = new();
+    public List<string> Meters { get; } = [];
 
-    public List<object> Instrumentation { get; } = new();
+    public List<object> Instrumentation { get; } = [];
 
     public MeterProvider? Provider { get; private set; }
 

test/OpenTelemetry.Api.ProviderBuilderExtensions.Tests/OpenTelemetry.Api.ProviderBuilderExtensions.Tests.csproj

@@ -1,7 +1,8 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <Description>Unit test project for OpenTelemetry .NET dependency injection extensions</Description>
     <TargetFrameworks>$(TargetFrameworksForTests)</TargetFrameworks>
+    <AnalysisLevel>latest-all</AnalysisLevel>
   </PropertyGroup>
 
   <ItemGroup>

test/OpenTelemetry.Api.ProviderBuilderExtensions.Tests/ServiceCollectionExtensionsTests.cs

@@ -30,7 +30,7 @@ public void ConfigureOpenTelemetryTracerProvider(int numberOfCalls)
 
         using var serviceProvider = services.BuildServiceProvider();
 
-        var registrations = serviceProvider.GetServices<IConfigureTracerProviderBuilder>();
+        var registrations = serviceProvider.GetServices<IConfigureTracerProviderBuilder>().ToArray();
 
         Assert.Equal(numberOfCalls, beforeServiceProviderInvocations);
         Assert.Equal(0, afterServiceProviderInvocations);
@@ -43,7 +43,7 @@ public void ConfigureOpenTelemetryTracerProvider(int numberOfCalls)
         Assert.Equal(numberOfCalls, beforeServiceProviderInvocations);
         Assert.Equal(numberOfCalls, afterServiceProviderInvocations);
 
-        Assert.Equal(numberOfCalls * 2, registrations.Count());
+        Assert.Equal(numberOfCalls * 2, registrations.Length);
     }
 
     [Theory]
@@ -65,7 +65,7 @@ public void ConfigureOpenTelemetryMeterProvider(int numberOfCalls)
 
         using var serviceProvider = services.BuildServiceProvider();
 
-        var registrations = serviceProvider.GetServices<IConfigureMeterProviderBuilder>();
+        var registrations = serviceProvider.GetServices<IConfigureMeterProviderBuilder>().ToArray();
 
         Assert.Equal(numberOfCalls, beforeServiceProviderInvocations);
         Assert.Equal(0, afterServiceProviderInvocations);
@@ -78,7 +78,7 @@ public void ConfigureOpenTelemetryMeterProvider(int numberOfCalls)
         Assert.Equal(numberOfCalls, beforeServiceProviderInvocations);
         Assert.Equal(numberOfCalls, afterServiceProviderInvocations);
 
-        Assert.Equal(numberOfCalls * 2, registrations.Count());
+        Assert.Equal(numberOfCalls * 2, registrations.Length);
     }
 
     [Theory]
@@ -100,7 +100,7 @@ public void ConfigureOpenTelemetryLoggerProvider(int numberOfCalls)
 
         using var serviceProvider = services.BuildServiceProvider();
 
-        var registrations = serviceProvider.GetServices<IConfigureLoggerProviderBuilder>();
+        var registrations = serviceProvider.GetServices<IConfigureLoggerProviderBuilder>().ToArray();
 
         Assert.Equal(numberOfCalls, beforeServiceProviderInvocations);
         Assert.Equal(0, afterServiceProviderInvocations);
@@ -113,6 +113,6 @@ public void ConfigureOpenTelemetryLoggerProvider(int numberOfCalls)
         Assert.Equal(numberOfCalls, beforeServiceProviderInvocations);
         Assert.Equal(numberOfCalls, afterServiceProviderInvocations);
 
-        Assert.Equal(numberOfCalls * 2, registrations.Count());
+        Assert.Equal(numberOfCalls * 2, registrations.Length);
     }
 }

test/OpenTelemetry.Api.ProviderBuilderExtensions.Tests/Trace/TestTracerProviderBuilder.cs

@@ -6,7 +6,7 @@
 
 namespace OpenTelemetry.Api.ProviderBuilderExtensions.Tests;
 
-public sealed class TestTracerProviderBuilder : TracerProviderBuilder, ITracerProviderBuilder, IDisposable
+internal sealed class TestTracerProviderBuilder : TracerProviderBuilder, ITracerProviderBuilder, IDisposable
 {
     public TestTracerProviderBuilder()
     {
@@ -17,11 +17,11 @@ public TestTracerProviderBuilder()
 
     public ServiceProvider? ServiceProvider { get; private set; }
 
-    public List<string> Sources { get; } = new();
+    public List<string> Sources { get; } = [];
 
-    public List<string> LegacySources { get; } = new();
+    public List<string> LegacySources { get; } = [];
 
-    public List<object> Instrumentation { get; } = new();
+    public List<object> Instrumentation { get; } = [];
 
     public TracerProvider? Provider { get; private set; }