Skip to content

Commit 6ebad82

Browse files
committed
sqlclient: remove duplicate db.system settag
1 parent 97e8a6c commit 6ebad82

2 files changed

Lines changed: 0 additions & 2 deletions

File tree

src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlClientDiagnosticListener.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ public override void OnCustom(string name, Activity activity, object payload)
8787
_ = this.dataSourceFetcher.TryFetch(connection, out var dataSource);
8888
_ = this.commandTextFetcher.TryFetch(command, out var commandText);
8989

90-
activity.SetTag(SemanticConventions.AttributeDbSystem, SqlActivitySourceHelper.MicrosoftSqlServerDatabaseSystemName);
9190
activity.SetTag(SemanticConventions.AttributeDbName, (string)database);
9291

9392
this.options.AddConnectionLevelDetailsToActivity((string)dataSource, activity);

src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlEventSourceListener.netfx.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,6 @@ private void OnBeginExecute(EventWrittenEventArgs eventData)
143143

144144
if (activity.IsAllDataRequested)
145145
{
146-
activity.SetTag(SemanticConventions.AttributeDbSystem, SqlActivitySourceHelper.MicrosoftSqlServerDatabaseSystemName);
147146
activity.SetTag(SemanticConventions.AttributeDbName, databaseName);
148147

149148
this.options.AddConnectionLevelDetailsToActivity((string)eventData.Payload[1], activity);

0 commit comments

Comments
 (0)