Skip to content

Update SqlInstrumentation ActivitySource name#3435

Merged
utpilla merged 4 commits into
open-telemetry:mainfrom
utpilla:utpilla/Update-SQLInstrumentation-ActivitySource
Jul 11, 2022
Merged

Update SqlInstrumentation ActivitySource name#3435
utpilla merged 4 commits into
open-telemetry:mainfrom
utpilla:utpilla/Update-SQLInstrumentation-ActivitySource

Conversation

@utpilla
Copy link
Copy Markdown
Contributor

@utpilla utpilla commented Jul 9, 2022

Changes

  • Update SqlInstrumentation ActivitySource name to "OpenTelemetry.Instrumentation.SqlClient"
  • Appropriate CHANGELOG.md updated for non-trivial changes

@utpilla utpilla requested a review from a team July 9, 2022 00:24
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 9, 2022

Codecov Report

Merging #3435 (25c2c3e) into main (be588bd) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3435      +/-   ##
==========================================
- Coverage   86.29%   86.27%   -0.02%     
==========================================
  Files         263      263              
  Lines        9542     9545       +3     
==========================================
+ Hits         8234     8235       +1     
- Misses       1308     1310       +2     
Impacted Files Coverage Δ
...qlClient/Implementation/SqlActivitySourceHelper.cs 100.00% <100.00%> (ø)
...metryProtocol/Implementation/ActivityExtensions.cs 94.50% <0.00%> (-1.10%) ⬇️

@utpilla utpilla merged commit be6ab71 into open-telemetry:main Jul 11, 2022
@utpilla utpilla deleted the utpilla/Update-SQLInstrumentation-ActivitySource branch November 3, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants