Add ibm-mq-metrics #1960
Add ibm-mq-metrics #1960
Conversation
|
❌ The result from spotlessApply could not be committed to the PR branch, see logs: https://github.com/open-telemetry/opentelemetry-java-contrib/actions/runs/15645359085. |
|
🔧 The result from spotlessApply was committed to the PR branch. |
3 similar comments
|
🔧 The result from spotlessApply was committed to the PR branch. |
|
🔧 The result from spotlessApply was committed to the PR branch. |
|
🔧 The result from spotlessApply was committed to the PR branch. |
… (instead of duplicating these strings everywhere!)
ibm-mq-metrics/src/integrationTest/resources/conf/test-queuemgr-config.yml
Outdated
Show resolved
Hide resolved
|
Ok, so I've done an update that does the following:
Thanks for looking. |
|
thank you @breedx-splk for all the update! So we are waiting for @trask to give the final blessing? |
Not necessarily @trask, but any of the approvers/maintainers of this repo. |
| 1. Configure the IBM SSL Cipher Suite in the config.yml. | ||
| Note that, to use some CipherSuites the unrestricted policy needs to be configured in JRE. | ||
| Please visit [this link](http://www.ibm.com/support/knowledgecenter/SSYKE2_8.0.0/com.ibm.java.security.component.80.doc/security-component/sdkpolicyfiles.html) | ||
| for more details. For Oracle JRE, please update with [JCE Unlimited Strength Jurisdiction Policy](http://www.oracle.com/technetwork/java/javase/downloads/jce8-download-2133166.html). |
There was a problem hiding this comment.
I think it would be a good idea to mention that this is not needed on oracle 9 and later and also in 8 since u161 https://www.oracle.com/java/technologies/javase/8u161-relnotes.html#JDK-8170157
There was a problem hiding this comment.
Seems then like it would be safe to say just "java 8 below 8u161" then right?
ibm-mq-metrics/src/main/java/io/opentelemetry/ibm/mq/WmqMonitor.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,20 @@ | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
There was a problem hiding this comment.
as far as I can tell tests don't include log4j
| @@ -0,0 +1,59 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
as far as I can tell log4j isn't included in the fat jar
| ConfigWrapper config, ScheduledExecutorService service, OpenTelemetry otel) { | ||
| MeterProvider meterProvider = otel.getMeterProvider(); | ||
|
|
||
| Runtime.getRuntime().addShutdownHook(new Thread(service::shutdown)); |
There was a problem hiding this comment.
I suspect that this doesn't do anything. Since the ScheduledExecutorService used here doesn't use daemon threads (and if it did then app would terminate when the main thread exits).
ibm-mq-metrics/src/main/java/io/opentelemetry/ibm/mq/opentelemetry/Main.java
Outdated
Show resolved
Hide resolved
remove appd extension troubleshooting tips
This is the first part of #1941. It adds a new component called
ibm-mq-metricswhich provides a runnable utility that can fetch metrics from IBM MQ series and emit them as otel metrics. It is based on https://github.com/signalfx/opentelemetry-ibm-mq-monitoring. This code is alpha quality.There are a few pieces that are still missing from this PR:
goldenimage only being available in a splunk registry (see #40721 for more info)integrationTesttarget. This requires running the ibm mq server as a docker container, which is not yet included.