Skip to content

Standardize project-wide Testcontainers service registration - #20951

Open
trask with Copilot wants to merge 5 commits into
mainfrom
copilot/fresh-cloud-attempt
Open

trask with Copilot wants to merge 5 commits into
mainfrom
copilot/fresh-cloud-attempt

Conversation

Copilot AI commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Standardize Testcontainers service registration across 10 Gradle scripts and the Gradle review instruction. Multi-task projects use one shared declaration for all Test tasks, accepting brief slot use by container-free variants rather than filtering task names.

Single-task projects keep test {}; implicit latestDepTest does not count as a second task. Test selections, dependencies, task wiring, and the two-slot concurrency limit stay unchanged.

The requested knowledge-article update remains incomplete because the cloud environment denied access to .github/agents.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Waiting on reviewers · refreshed 2026-10-25 20:22 UTC

Review the latest changes.

Also blocked by: Merge conflicts.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot AI changed the title [WIP] Create new draft for combined documentation and Gradle alignment Standardize project-wide Testcontainers service registration Oct 24, 2026
Copilot AI requested a review from trask October 24, 2026 22:36
@trask
trask requested a balanced review from Copilot October 24, 2026 22:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes consistently implement the intended scheduling policy, preserve unrelated test configuration, and leave no identified blocking issues.

No open issues 🎉

What changed in this PR

This PR standardizes Testcontainers resource scheduling across OpenTelemetry Java instrumentation and starter smoke tests, using one project-wide service declaration.

Changes:

  • Normalize 16 Gradle scripts so every Test task uses the shared Testcontainers service.
  • Remove task-specific registrations and exclusions while preserving test selections, properties, dependencies, wiring, and the concurrency limit of two.
  • Update build-review guidance to document the project-wide default and scheduling-based exceptions.
File Description
smoke-tests-otel-starter/​spring-boot-4/​build.gradle.kts Apply registration to all test tasks.
instrumentation/​vertx/​vertx-sql-client/​vertx-sql-client-5.0/​javaagent/​build.gradle.kts Separate unconditional registration from filtered properties.
instrumentation/​spring/​spring-rabbit-1.1/​javaagent/​build.gradle.kts Remove service-registration task exclusions.
instrumentation/​spring/​spring-kafka-2.7/​library/​build.gradle.kts Broaden registration while retaining test-specific properties.
instrumentation/​spring/​spring-jms/​spring-jms-6.0/​javaagent/​build.gradle.kts Remove redundant per-task registration.
instrumentation/​spring/​spring-integration-4.1/​library/​build.gradle.kts Add project-wide registration.
instrumentation/​spring/​spring-integration-4.1/​javaagent/​build.gradle.kts Include the version-specific test task.
instrumentation/​reactor/​reactor-kafka-1.0/​javaagent/​build.gradle.kts Remove the unit-test exclusion.
instrumentation/​oracle-ucp-11.2/​testing/​build.gradle.kts Apply registration to all test tasks.
instrumentation/​nats/​nats-2.17/​library/​build.gradle.kts Apply registration to all library test tasks.
instrumentation/​nats/​nats-2.17/​javaagent/​build.gradle.kts Apply registration to all agent test tasks.
instrumentation/​mongo/​mongo-3.1/​library/​build.gradle.kts Apply registration to all test tasks.
instrumentation/​kafka/​kafka-streams-0.11/​javaagent/​build.gradle.kts Broaden registration without broadening system properties.
instrumentation/​jmx-metrics/​library/​build.gradle.kts Consolidate registrations in shared test configuration.
instrumentation/​jms/​jms-1.1/​javaagent/​build.gradle.kts Replace individual registrations with one shared declaration.
instrumentation/​aws-sdk/​aws-sdk-2.2/​javaagent/​build.gradle.kts Replace suite-specific registration with project-wide registration.
.github/​instructions/​instrumentation-gradle.instructions.md Document unconditional registration and its exception criteria.

Review effort: Balanced

Comment thread .github/instructions/instrumentation-gradle.instructions.md Outdated
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot AI requested a review from trask October 24, 2026 23:01
@trask
trask requested a balanced review from Copilot October 24, 2026 23:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused changes implement the stated registration policy while preserving task-specific configuration, with no unresolved blocking findings.

No open issues 🎉

Review effort: Balanced

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Comment thread instrumentation/kafka/kafka-streams-0.11/javaagent/build.gradle.kts Outdated
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot AI requested a review from trask October 24, 2026 23:27
@trask
trask requested a balanced review from Copilot October 24, 2026 23:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes consistently implement the intended scheduling policy without altering test wiring or concurrency limits, and no blocking defects were identified.

No open issues 🎉

Review effort: Balanced

@trask
trask marked this pull request as ready for review October 24, 2026 23:41
@trask
trask requested a review from a team as a code owner October 24, 2026 23:41

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants