Repository navigation
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-10-25 20:22 UTC Review the latest changes. Also blocked by: Merge conflicts. Status above doesn't look right?
|
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Create new draft for combined documentation and Gradle alignment
Standardize project-wide Testcontainers service registration
Oct 24, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently implement the intended scheduling policy, preserve unrelated test configuration, and leave no identified blocking issues.
No open issues 🎉
What changed in this PR
This PR standardizes Testcontainers resource scheduling across OpenTelemetry Java instrumentation and starter smoke tests, using one project-wide service declaration.
Changes:
- Normalize 16 Gradle scripts so every
Testtask uses the shared Testcontainers service. - Remove task-specific registrations and exclusions while preserving test selections, properties, dependencies, wiring, and the concurrency limit of two.
- Update build-review guidance to document the project-wide default and scheduling-based exceptions.
| File | Description |
|---|---|
smoke-tests-otel-starter/spring-boot-4/build.gradle.kts |
Apply registration to all test tasks. |
instrumentation/vertx/vertx-sql-client/vertx-sql-client-5.0/javaagent/build.gradle.kts |
Separate unconditional registration from filtered properties. |
instrumentation/spring/spring-rabbit-1.1/javaagent/build.gradle.kts |
Remove service-registration task exclusions. |
instrumentation/spring/spring-kafka-2.7/library/build.gradle.kts |
Broaden registration while retaining test-specific properties. |
instrumentation/spring/spring-jms/spring-jms-6.0/javaagent/build.gradle.kts |
Remove redundant per-task registration. |
instrumentation/spring/spring-integration-4.1/library/build.gradle.kts |
Add project-wide registration. |
instrumentation/spring/spring-integration-4.1/javaagent/build.gradle.kts |
Include the version-specific test task. |
instrumentation/reactor/reactor-kafka-1.0/javaagent/build.gradle.kts |
Remove the unit-test exclusion. |
instrumentation/oracle-ucp-11.2/testing/build.gradle.kts |
Apply registration to all test tasks. |
instrumentation/nats/nats-2.17/library/build.gradle.kts |
Apply registration to all library test tasks. |
instrumentation/nats/nats-2.17/javaagent/build.gradle.kts |
Apply registration to all agent test tasks. |
instrumentation/mongo/mongo-3.1/library/build.gradle.kts |
Apply registration to all test tasks. |
instrumentation/kafka/kafka-streams-0.11/javaagent/build.gradle.kts |
Broaden registration without broadening system properties. |
instrumentation/jmx-metrics/library/build.gradle.kts |
Consolidate registrations in shared test configuration. |
instrumentation/jms/jms-1.1/javaagent/build.gradle.kts |
Replace individual registrations with one shared declaration. |
instrumentation/aws-sdk/aws-sdk-2.2/javaagent/build.gradle.kts |
Replace suite-specific registration with project-wide registration. |
.github/instructions/instrumentation-gradle.instructions.md |
Document unconditional registration and its exception criteria. |
Review effort: Balanced
trask
reviewed
Oct 24, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
trask
reviewed
Oct 24, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
marked this pull request as ready for review
October 24, 2026 23:41
trask
approved these changes
Oct 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize Testcontainers service registration across 10 Gradle scripts and the Gradle review instruction. Multi-task projects use one shared declaration for all
Testtasks, accepting brief slot use by container-free variants rather than filtering task names.Single-task projects keep
test {}; implicitlatestDepTestdoes not count as a second task. Test selections, dependencies, task wiring, and the two-slot concurrency limit stay unchanged.The requested knowledge-article update remains incomplete because the cloud environment denied access to
.github/agents.