Repository navigation
Commit db837ce
Address Copilot review comment: regenerate Python coverage
Copilot comment:
Changing this request to `/users/456` creates additional signal names for route-less servers, but their committed coverage was not regenerated. The ASGI snapshot currently contains only `GET /users/123` and its receive/send child findings (`scenarios/http/python/asgi/opentelemetry-asgi/server/data.json:153-179`), and WSGI likewise only contains `GET /users/123` (`scenarios/http/python/wsgi/opentelemetry-wsgi/server/data.json:86-94`). The Python scenario CI reruns every package and rejects coverage diffs, so these snapshots will change when the query request is emitted as `/users/456`. Please regenerate and commit the affected existing server `data.json` files.
Analysis: ASGI and WSGI omit `http.route`, so their span names use each concrete request path. The distinct query path adds `GET /users/456` findings while preserving the findings for the query-free `/users/123` request. Regenerating both scenarios records the additional server and ASGI child-span findings.
Upsides: The committed coverage now matches the shared contract for every route-less server scenario. Python scenario CI no longer finds stale snapshots.
Downsides: The coverage files contain more findings because each concrete user path remains a separate unbounded-cardinality span name until those instrumentations emit `http.route`.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 70d4161 commit db837ce
2 files changed
Lines changed: 38 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
181 | 209 | | |
182 | 210 | | |
183 | 211 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
96 | 106 | | |
97 | 107 | | |
98 | 108 | | |
| |||
0 commit comments