Skip to content

Commit 264879c

Browse files
committed
Make network.type opt-in
1 parent cee22ec commit 264879c

File tree

3 files changed

+2
-11
lines changed

3 files changed

+2
-11
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ release.
1111

1212
- BREAKING: Rename http.resend_count to http.request.resend_count.
1313
([#374](https://github.com/open-telemetry/semantic-conventions/pull/374))
14+
- BREAKING: Change `network.type` from recommended to opt-in in HTTP semconv.
15+
([#999](https://github.com/open-telemetry/semantic-conventions/pull/999))
1416

1517
### Features
1618

docs/http/http-spans.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ sections below.
126126
| [`network.protocol.name`](../general/attributes.md) | string | [OSI application layer](https://osi-model.com/application-layer/) or non-OSI equivalent. [6] | `http`; `spdy` | Recommended: if not default (`http`). |
127127
| [`network.protocol.version`](../general/attributes.md) | string | Version of the protocol specified in `network.protocol.name`. [7] | `1.0`; `1.1`; `2`; `3` | Recommended |
128128
| [`network.transport`](../general/attributes.md) | string | [OSI transport layer](https://osi-model.com/transport-layer/) or [inter-process communication method](https://en.wikipedia.org/wiki/Inter-process_communication). [8] | `tcp`; `udp` | Conditionally Required: [9] |
129-
| [`network.type`](../general/attributes.md) | string | [OSI network layer](https://osi-model.com/network-layer/) or non-OSI equivalent. [10] | `ipv4`; `ipv6` | Recommended |
130129
| `user_agent.original` | string | Value of the [HTTP User-Agent](https://www.rfc-editor.org/rfc/rfc9110.html#field.user-agent) header sent by the client. | `CERN-LineMode/2.15 libwww/2.17b3` | Recommended |
131130

132131
**[1]:** If the request fails with an error before response status code was sent or received,
@@ -183,8 +182,6 @@ different processes could be listening on TCP port 12345 and UDP port 12345.
183182

184183
**[9]:** If not default (`tcp` for `HTTP/1.1` and `HTTP/2`, `udp` for `HTTP/3`).
185184

186-
**[10]:** The value SHOULD be normalized to lowercase.
187-
188185
Following attributes MUST be provided **at span creation time** (when provided at all), so they can be considered for sampling decisions:
189186

190187
* [`http.request.method`](../attributes-registry/http.md)
@@ -218,13 +215,6 @@ Following attributes MUST be provided **at span creation time** (when provided a
218215
| `udp` | UDP |
219216
| `pipe` | Named or anonymous pipe. See note below. |
220217
| `unix` | Unix domain socket |
221-
222-
`network.type` has the following list of well-known values. If one of them applies, then the respective value MUST be used, otherwise a custom value MAY be used.
223-
224-
| Value | Description |
225-
|---|---|
226-
| `ipv4` | IPv4 |
227-
| `ipv6` | IPv6 |
228218
<!-- endsemconv -->
229219

230220
## HTTP client

model/trace/http.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ groups:
2222
- ref: network.transport
2323
requirement_level:
2424
conditionally_required: If not default (`tcp` for `HTTP/1.1` and `HTTP/2`, `udp` for `HTTP/3`).
25-
- ref: network.type
2625
- ref: user_agent.original
2726

2827
- id: trace.http.client

0 commit comments

Comments
 (0)