Skip to content

GetBatch incorrect method accessibility #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agolaszewski opened this issue Jan 25, 2025 · 4 comments
Open

GetBatch incorrect method accessibility #328

agolaszewski opened this issue Jan 25, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@agolaszewski
Copy link

Service

OpenAI

Describe the bug

Methods GetBatchAsync and GetBatch are marked as internal and therefore, are not accessible outside the package. I believe this is a mistake

internal virtual async Task<ClientResult> GetBatchAsync(string batchId, RequestOptions options)

Steps to reproduce

.

Code snippets

OS

winOS

.NET version

8.0

Library version

2.1.0

@agolaszewski agolaszewski added the bug Something isn't working label Jan 25, 2025
@wdqzdd
Copy link

wdqzdd commented Mar 4, 2025

big bug

@LuisM000
Copy link

LuisM000 commented Mar 13, 2025

I am also affected by this issue. In my case, I am using AzureOpenAI, and while the overridden method is public, since I need to use the BatchClient class, I am facing the same issue: it is not accessible. This is a major problem for me. For reference, the overridden method is marked as public in this link.

Additionally, @mickaelMamani created a PR to fix this issue: PR #262, but it seems to have been forgotten. :(

@rliberoff
Copy link

I thought I was the only one. I also have this very same issue.

Any possibility to have it fixed?

@mickaelMamani
Copy link

it comforts me to see people supporting me to push my PR (#262)

(@rliberoff : your youtube channel is very cool ! I just subscribed 👍 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants