Skip to content

Commit 157add6

Browse files
pfedinKAGA-KOKO
authored andcommitted
irqchip/GICv2m: Fix GICv2m build warning on 32 bits
After GICv2m was enabled for 32-bit ARM kernel, a warning popped up: drivers/irqchip/irq-gic-v2m.c: In function gicv2m_compose_msi_msg: drivers/irqchip/irq-gic-v2m.c:100:2: warning: right shift count >= width of type [enabled by default] msg->address_hi = (u32) (addr >> 32); ^ This patch fixes it by using proper macros for splitting up the value. Signed-off-by: Pavel Fedin <[email protected]> Reviewed-by: Marc Zyngier <[email protected]> Signed-off-by: Marc Zyngier <[email protected]> Cc: [email protected] Cc: Stuart Yoder <[email protected]> Cc: Jason Cooper <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Thomas Gleixner <[email protected]>
1 parent 5a9a891 commit 157add6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/irqchip/irq-gic-v2m.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ static void gicv2m_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
9595
struct v2m_data *v2m = irq_data_get_irq_chip_data(data);
9696
phys_addr_t addr = v2m->res.start + V2M_MSI_SETSPI_NS;
9797

98-
msg->address_hi = (u32) (addr >> 32);
99-
msg->address_lo = (u32) (addr);
98+
msg->address_hi = upper_32_bits(addr);
99+
msg->address_lo = lower_32_bits(addr);
100100
msg->data = data->hwirq;
101101
}
102102

0 commit comments

Comments
 (0)