Skip to content

Commit 6cdc67b

Browse files
Mikulas Patockagregkh
authored andcommitted
dm writecache: fix a crash due to reading past end of dirty_bitmap
commit 1e1132e upstream. wc->dirty_bitmap_size is in bytes so must multiply it by 8, not by BITS_PER_LONG, to get number of bitmap_bits. Fixes crash in find_next_bit() that was reported: https://bugzilla.kernel.org/show_bug.cgi?id=200819 Reported-by: [email protected] Fixes: 48debaf ("dm: add writecache target") Cc: [email protected] # 4.18 Signed-off-by: Mikulas Patocka <[email protected]> Signed-off-by: Mike Snitzer <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent d94cf70 commit 6cdc67b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/md/dm-writecache.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ static void ssd_commit_flushed(struct dm_writecache *wc)
457457
COMPLETION_INITIALIZER_ONSTACK(endio.c),
458458
ATOMIC_INIT(1),
459459
};
460-
unsigned bitmap_bits = wc->dirty_bitmap_size * BITS_PER_LONG;
460+
unsigned bitmap_bits = wc->dirty_bitmap_size * 8;
461461
unsigned i = 0;
462462

463463
while (1) {

0 commit comments

Comments
 (0)