mtd: nand: sunxi: fix sunxi_nand_chips_cleanup()

Boris BREZILLON · computersforpeace · commit 8e375ccda31c · 2015-09-21T17:11:59.000-07:00
The sunxi_nand_chips_cleanup() function is missing a call to list_del() which generates a double free error. Reported-by: Priit Laes <plaes@plaes.org> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> Cc: <stable@vger.kernel.org> # 3.19+ Fixes: 1fef62c ("mtd: nand: add sunxi NAND flash controller support") Tested-by: Priit Laes <plaes@plaes.org> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
diff --git a/drivers/mtd/nand/sunxi_nand.c b/drivers/mtd/nand/sunxi_nand.c
@@ -1381,6 +1381,7 @@ static void sunxi_nand_chips_cleanup(struct sunxi_nfc *nfc)
 					node);
 		nand_release(&chip->mtd);
 		sunxi_nand_ecc_cleanup(&chip->nand.ecc);
+		list_del(&chip->node);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1381,6 +1381,7 @@ static void sunxi_nand_chips_cleanup(struct sunxi_nfc *nfc)`
`1381`	`1381`	`node);`
`1382`	`1382`	`nand_release(&chip->mtd);`
`1383`	`1383`	`sunxi_nand_ecc_cleanup(&chip->nand.ecc);`
	`1384`	`+ list_del(&chip->node);`
`1384`	`1385`	`}`
`1385`	`1386`	`}`
`1386`	`1387`