fix: address PR review — reason guard, one-shot fetch, index scan

- Reject empty reason strings in setSoftDeleted calls + re-add .catch()
  for error feedback (both reported-skills and skill-tools sections)
- Replace useQuery with ConvexHttpClient.query() on /users public
  browse page per CLAUDE.md policy
- Add by_active_handle compound index on users table to avoid full
  table scan in queryUsersForPublicList

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: BunsDev

convex/schema.ts

@@ -40,7 +40,8 @@ const users = defineTable({
 })
   .index("email", ["email"])
   .index("phone", ["phone"])
-  .index("handle", ["handle"]);
+  .index("handle", ["handle"])
+  .index("by_active_handle", ["deletedAt", "deactivatedAt", "handle"]);
 
 const publishers = defineTable({
   kind: v.union(v.literal("user"), v.literal("org")),

convex/users.ts

@@ -443,10 +443,12 @@ async function queryUsersForPublicList(
   const scanLimit = normalizedSearch
     ? computeUserSearchScanLimit(args.limit)
     : clampInt(args.limit * 6, args.limit, MAX_USER_SEARCH_SCAN);
-  const scannedUsers = await ctx.db.query("users").order("desc").take(scanLimit);
-  const activeUsers = scannedUsers.filter(
-    (user) => !user.deletedAt && !user.deactivatedAt && Boolean(user.handle),
-  );
+  const scannedUsers = await ctx.db
+    .query("users")
+    .withIndex("by_active_handle", (q) => q.eq("deletedAt", undefined).eq("deactivatedAt", undefined))
+    .order("desc")
+    .take(scanLimit);
+  const activeUsers = scannedUsers.filter((user) => Boolean(user.handle));
   const result = buildUserSearchResults(activeUsers, normalizedSearch);
   return {
     items: result.items.slice(0, args.limit),

src/routes/management.tsx

@@ -331,12 +331,12 @@ function Management() {
                         const reason = window.prompt(
                           skill.softDeletedAt ? "Restore reason:" : "Hide reason:",
                         );
-                        if (reason === null) return;
+                        if (!reason?.trim()) return;
                         void setSoftDeleted({
                           skillId: skill._id,
                           deleted: !skill.softDeletedAt,
-                          reason,
-                        });
+                          reason: reason.trim(),
+                        }).catch((error) => window.alert(formatMutationError(error)));
                       }}
                     >
                       {skill.softDeletedAt ? "Restore" : "Hide"}
@@ -600,12 +600,12 @@ function Management() {
                         const reason = window.prompt(
                           skill.softDeletedAt ? "Restore reason:" : "Hide reason:",
                         );
-                        if (reason === null) return;
+                        if (!reason?.trim()) return;
                         void setSoftDeleted({
                           skillId: skill._id,
                           deleted: !skill.softDeletedAt,
-                          reason,
-                        });
+                          reason: reason.trim(),
+                        }).catch((error) => window.alert(formatMutationError(error)));
                       }}
                     >
                       {skill.softDeletedAt ? "Restore" : "Hide"}

src/routes/users/index.tsx

@@ -1,15 +1,17 @@
 import { createFileRoute } from "@tanstack/react-router";
-import { useQuery } from "convex/react";
 import { Search } from "lucide-react";
-import { useEffect, useState } from "react";
+import { useCallback, useEffect, useState } from "react";
 import { api } from "../../../convex/_generated/api";
 import { UserListItem } from "../../components/UserListItem";
+import { convexHttp } from "../../convex/client";
 import type { PublicUser } from "../../lib/publicUser";
 
 type UserSearchState = {
   q?: string;
 };
 
+type UsersLoaderResult = { items: PublicUser[]; total: number };
+
 export const Route = createFileRoute("/users/")({
   validateSearch: (search): UserSearchState => ({
     q: typeof search.q === "string" && search.q.trim() ? search.q.trim() : undefined,
@@ -21,15 +23,26 @@ function UsersIndex() {
   const search = Route.useSearch();
   const navigate = Route.useNavigate();
   const [query, setQuery] = useState(search.q ?? "");
+  const [result, setResult] = useState<UsersLoaderResult | undefined>(undefined);
+  const [loading, setLoading] = useState(true);
+
+  const fetchUsers = useCallback(async (q?: string) => {
+    setLoading(true);
+    try {
+      const data = await convexHttp.query(api.users.listPublic, {
+        limit: 48,
+        search: q,
+      });
+      setResult(data as UsersLoaderResult);
+    } finally {
+      setLoading(false);
+    }
+  }, []);
 
   useEffect(() => {
     setQuery(search.q ?? "");
-  }, [search.q]);
-
-  const result = useQuery(api.users.listPublic, {
-    limit: 48,
-    search: search.q,
-  }) as { items: PublicUser[]; total: number } | undefined;
+    void fetchUsers(search.q);
+  }, [search.q, fetchUsers]);
 
   const users = result?.items ?? [];
 
@@ -66,11 +79,11 @@ function UsersIndex() {
       <div className="browse-results">
         <div className="browse-results-toolbar">
           <span className="browse-results-count">
-            {result === undefined ? "Loading users..." : `${users.length} users`}
+            {loading ? "Loading users..." : `${users.length} users`}
           </span>
         </div>
 
-        {result === undefined ? (
+        {loading ? (
           <div className="card">
             <div className="loading-indicator">Loading users...</div>
           </div>