Skip to content

Charuco Behavior in opencv-python-contrib #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kopecn opened this issue Jun 30, 2022 · 4 comments
Closed

Charuco Behavior in opencv-python-contrib #686

kopecn opened this issue Jun 30, 2022 · 4 comments
Assignees

Comments

@kopecn
Copy link

kopecn commented Jun 30, 2022

our unit tests for charuco handling have started breaking in 4.6.0.66 and was uniformly passing in 4.5.5.64 and earlier.

Has there been any major changes that could impact --> cv2.aruco.detectMarkers going from 4.5 to 4.6?

Let me know what sample code is needed to help out.

@asmorkalov
Copy link
Collaborator

There were a lot of fixes in Aruco and related code: https://github.com/opencv/opencv_contrib/pulls?q=is%3Apr+is%3Aclosed+label%3A%22category%3A+aruco%22

@kopecn
Copy link
Author

kopecn commented Jul 5, 2022

I was able to dig a bit more, and see that the cv2.aruco.CharucoBoard_create does different layout for charuco, and wanted to ask if this was the expected behavior. Perhaps fixing something that was previously wrong?

board = cv2.aruco.CharucoBoard_create(
10,
10,
0.0337,
0.02696,
5,
)

image

@AleksandrPanov
Copy link

@kopecn there is behavior change only with even row count. There were several bugs: opencv/opencv_contrib#2623, opencv/opencv_contrib#2604

This path fixed this and now CharucoBoard behavior is aligned with chessboard: https://github.com/opencv/opencv/blob/4.x/doc/pattern.png

You can use the suggested patch in #3291 issue. But it is recommended to use new patterns, as the calibration might not work correctly on old patterns.

@asmorkalov asmorkalov pinned this issue Jul 6, 2022
@kopecn
Copy link
Author

kopecn commented Jul 6, 2022

Excellent! Thank you for the help/feedback! We will make the adjustments as you recommend and update our old patterns.

@asmorkalov asmorkalov unpinned this issue Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants