Skip to content

Commit 4ba3ab1

Browse files
Enable mcad_ray_test
1 parent 05d144b commit 4ba3ab1

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

tests/integration/mcad_ray_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ import (
3434
func TestMCADRay(t *testing.T) {
3535
test := cfosupport.With(t)
3636

37-
test.T().Skip("Requires https://github.com/project-codeflare/codeflare-sdk/issues/190")
38-
3937
// Create a namespace
4038
namespace := test.NewTestNamespace()
4139

@@ -65,7 +63,7 @@ func TestMCADRay(t *testing.T) {
6563
policyRules := []rbacv1.PolicyRule{
6664
{
6765
Verbs: []string{"get", "create", "delete", "list", "patch", "update"},
68-
APIGroups: []string{mcadv1beta1.GroupName},
66+
APIGroups: []string{"workload.codeflare.dev"},
6967
Resources: []string{"appwrappers"},
7068
},
7169
{

tests/integration/resources/mnist_ray_mini.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"outputs": [],
4141
"source": [
4242
"# Create our cluster and submit appwrapper\n",
43-
"cluster = Cluster(ClusterConfiguration(namespace=namespace, name='mnisttest', num_workers=1, min_cpus=1, max_cpus=1, min_memory=4, max_memory=4, num_gpus=0, instascale=False))"
43+
"cluster = Cluster(ClusterConfiguration(namespace=namespace, name='mnistjob', num_workers=1, min_cpus=1, max_cpus=1, min_memory=4, max_memory=4, num_gpus=0, instascale=False))"
4444
]
4545
},
4646
{
@@ -99,7 +99,7 @@
9999
"metadata": {},
100100
"outputs": [],
101101
"source": [
102-
"job = DDPJobDefinition(name=\"mnisttest\", script=\"mnist.py\", workspace=\"file:///opt/app-root/notebooks/..data\", scheduler_args={\"requirements\": \"/opt/app-root/notebooks/requirements.txt\"}).submit(cluster)"
102+
"job = DDPJobDefinition(name=\"mnistjob\", script=\"mnist.py\", workspace=\"file:///opt/app-root/notebooks/..data\", scheduler_args={\"requirements\": \"/opt/app-root/notebooks/requirements.txt\"}).submit(cluster)"
103103
]
104104
},
105105
{

0 commit comments

Comments
 (0)