Skip to content

Commit bd00817

Browse files
Enable mcad_ray_test
1 parent 8b8563e commit bd00817

File tree

4 files changed

+6
-25
lines changed

4 files changed

+6
-25
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Integration of this stack into the Open Data Hub is owned by the Distributed Wor
2626
|------------------------------|---------|
2727
| CodeFlare Operator | v1.0.0-rc.1 |
2828
| Multi-Cluster App Dispatcher | v1.35.0 |
29-
| CodeFlare-SDK | v0.8.0 |
29+
| CodeFlare-SDK | v0.10.1 |
3030
| InstaScale | v0.0.9 |
3131
| KubeRay | v0.6.0 |
3232
<!-- Compatibility Matrix end -->

codeflare-stack/base/codeflare-notebook-imagestream.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ spec:
1313
tags:
1414
- annotations:
1515
openshift.io/imported-from: quay.io/project-codeflare/notebook
16-
name: v0.8.0
16+
name: v0.10.1
1717
from:
1818
kind: DockerImage
19-
name: quay.io/project-codeflare/notebook:v0.8.0
19+
name: quay.io/project-codeflare/notebook:v0.10.1
2020
importPolicy:
2121
scheduled: true

tests/integration/mcad_ray_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ import (
3434
func TestMCADRay(t *testing.T) {
3535
test := cfosupport.With(t)
3636

37-
test.T().Skip("Requires https://github.com/project-codeflare/codeflare-sdk/issues/190")
38-
3937
// Create a namespace
4038
namespace := test.NewTestNamespace()
4139

@@ -89,7 +87,7 @@ func TestMCADRay(t *testing.T) {
8987
Should(
9088
And(
9189
HaveLen(1),
92-
ContainElement(WithTransform(cfosupport.AppWrapperName, HavePrefix("mnistjob"))),
90+
ContainElement(WithTransform(cfosupport.AppWrapperName, HavePrefix("mnisttest"))),
9391
ContainElement(WithTransform(cfosupport.AppWrapperState, Equal(mcadv1beta1.AppWrapperStateActive))),
9492
),
9593
)

tests/integration/resources/mnist_ray_mini.ipynb

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"outputs": [],
4141
"source": [
4242
"# Create our cluster and submit appwrapper\n",
43-
"cluster = Cluster(ClusterConfiguration(namespace=namespace, name='mnisttest', num_workers=1, min_cpus=1, max_cpus=1, min_memory=4, max_memory=4, num_gpus=0, instascale=False))"
43+
"cluster = Cluster(ClusterConfiguration(namespace=namespace, name='mnisttest', head_cpus=1, head_memory=2, num_workers=1, min_cpus=1, max_cpus=1, min_memory=4, max_memory=4, num_gpus=0, instascale=False))"
4444
]
4545
},
4646
{
@@ -53,18 +53,7 @@
5353
"outputs": [],
5454
"source": [
5555
"# Bring up the cluster\n",
56-
"cluster.up()"
57-
]
58-
},
59-
{
60-
"cell_type": "code",
61-
"execution_count": null,
62-
"id": "a99d5aff",
63-
"metadata": {
64-
"tags": []
65-
},
66-
"outputs": [],
67-
"source": [
56+
"cluster.up()\n",
6857
"cluster.wait_ready()"
6958
]
7059
},
@@ -116,12 +105,6 @@
116105
" finished = (str(status.state) == \"SUCCEEDED\")"
117106
]
118107
},
119-
{
120-
"cell_type": "markdown",
121-
"id": "885ad96b",
122-
"metadata": {},
123-
"source": []
124-
},
125108
{
126109
"cell_type": "code",
127110
"execution_count": null,

0 commit comments

Comments
 (0)