Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Commit fb83526

Browse files
committed
Disable sorting on workbench (#900)
* Disable sorting on workbench * Address comments
1 parent 87160b3 commit fb83526

File tree

4 files changed

+1009
-3195
lines changed

4 files changed

+1009
-3195
lines changed

workbench/public/components/QueryResults/QueryResults.test.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,9 @@ describe("<QueryResults with data/> spec", () => {
103103
// It tests Tab button
104104
await fireEvent.click(getAllByRole('tab')[5]);
105105

106+
// TODO: uncomment this test when sorting is fixed
106107
// It tests sorting
107-
await fireEvent.click(getAllByTestId('tableHeaderSortButton')[1]);
108+
// await fireEvent.click(getAllByTestId('tableHeaderSortButton')[1]);
108109

109110
// It tests pagination
110111
await fireEvent.click(getAllByLabelText('Page 2 of 2')[0]);
@@ -209,8 +210,9 @@ describe("<QueryResults with data/> spec", () => {
209210
// It tests Tab button
210211
await fireEvent.click(getAllByRole('tab')[5]);
211212

213+
// TODO: uncomment this test when sorting is fixed
212214
// It tests sorting
213-
await fireEvent.click(getAllByTestId('tableHeaderSortButton')[1]);
215+
// await fireEvent.click(getAllByTestId('tableHeaderSortButton')[1]);
214216

215217
// It tests pagination
216218
await fireEvent.click(getAllByLabelText('Page 2 of 2')[0]);

workbench/public/components/QueryResults/QueryResultsBody.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -601,9 +601,9 @@ class QueryResultsBody extends React.Component<QueryResultsBodyProps, QueryResul
601601
<EuiTableHeaderCell
602602
key={label}
603603
width={colwidth}
604-
onSort={this.onSort.bind(this, label)}
605-
isSorted={this.props.sortedColumn === label}
606-
isSortAscending={this.props.sortableProperties.isAscendingByName(label)}
604+
// onSort={this.onSort.bind(this, label)}
605+
// isSorted={this.props.sortedColumn === label}
606+
// isSortAscending={this.props.sortableProperties.isAscendingByName(label)}
607607
>
608608
{label}
609609
</EuiTableHeaderCell>

0 commit comments

Comments
 (0)