Skip to content

Commit e988250

Browse files
author
Feanil Patel
authored
Merge pull request #440 from openedx/feanil/ubuntu_upgrade
build: Switch to ubuntu-latest for builds
2 parents 186745a + 61aa006 commit e988250

File tree

7 files changed

+13
-21
lines changed

7 files changed

+13
-21
lines changed

.github/workflows/ci.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ on:
1010

1111
jobs:
1212
build:
13-
runs-on: ubuntu-20.04
13+
runs-on: ubuntu-latest
1414
steps:
1515
- name: Checkout
1616
uses: actions/checkout@v4
1717

1818
- name: Setup Nodejs
1919
uses: actions/setup-node@v4
2020
with:
21-
node-version: 18
21+
node-version: 20
2222

2323
- name: Export CHROME_BIN Env Variable
2424
run: export CHROME_BIN=chromium-browser
@@ -27,7 +27,7 @@ jobs:
2727
run: export DISPLAY=:99.0
2828

2929
- name: Install Ruby
30-
uses: ruby/setup-ruby@3783f195e29b74ae398d7caca108814bbafde90e
30+
uses: ruby/setup-ruby@v1
3131
with:
3232
ruby-version: 2.7.3
3333

@@ -38,11 +38,15 @@ jobs:
3838
run: bundle install
3939

4040
- name: Install Firefox
41-
run: |
42-
sudo apt-get update
43-
sudo apt-get install --no-install-recommends -y firefox xvfb
41+
uses: browser-actions/setup-firefox@v1
4442

4543
- name: Run Gulp
4644
uses: GabrielBB/xvfb-action@v1
4745
with:
4846
run: gulp default --ci
47+
48+
- name: Run Code Coverage
49+
uses: codecov/codecov-action@v4
50+
with:
51+
token: ${{ secrets.CODECOV_TOKEN }}
52+
fail_ci_if_error: true

.github/workflows/npm-publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
jobs:
88
release:
99
name: Release
10-
runs-on: ubuntu-20.04
10+
runs-on: ubuntu-latest
1111
steps:
1212
- name: Checkout
1313
uses: actions/checkout@v4

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
18
1+
20

gulp/tasks/coverage.js

Lines changed: 0 additions & 9 deletions
This file was deleted.

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
"eslint": "^8.35.0",
4343
"eslint-config-edx": "4.0.4",
4444
"gulp": "^4.0.2",
45-
"gulp-coveralls": "0.1.4",
4645
"gulp-gh-pages": "0.5.4",
4746
"gulp-rename": "2.0.0",
4847
"gulp-util": "3.0.8",
@@ -54,7 +53,6 @@
5453
"karma": "6.4.4",
5554
"karma-chrome-launcher": "^3.1.1",
5655
"karma-coverage": "2.2.1",
57-
"karma-coveralls": "2.1.0",
5856
"karma-firefox-launcher": "2.1.3",
5957
"karma-jasmine": "5.1.0",
6058
"karma-jasmine-html-reporter": "2.1.0",

test/karma.ci.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,6 @@ module.exports = function(config) {
1818
preprocessors: {
1919
'src/js/**/*.js': ['coverage']
2020
},
21-
reporters: ['spec', 'coverage', 'coveralls']
21+
reporters: ['spec', 'coverage']
2222
});
2323
};

test/karma.conf.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ module.exports = function(config, overrideOptions) {
7575
'karma-chrome-launcher',
7676
'karma-firefox-launcher',
7777
'karma-coverage',
78-
'karma-coveralls',
7978
'karma-sinon',
8079
'karma-jasmine-html-reporter',
8180
'karma-spec-reporter'

0 commit comments

Comments
 (0)