Skip to content

Commit 20d7b78

Browse files
threexcrpurdie
authored andcommitted
python3: skip readline limited history tests
Python 3.12.5 is failing a newer ptest for reading/writing limited history. Skip it for now until a proper fix (if any) is determined. The new test was added in python/cpython@263c7e6 The GitHub issue is here: python/cpython#121160 The aforementioned bug report suggests that OSErrors like that show up when using the GNU readline-based readline module if a workaround isn't also incorporated. It also mentions a new readline backend will be available in 3.13 that might help, but that won't be available for a year. Signed-off-by: Trevor Gamblin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
1 parent 84deba4 commit 20d7b78

File tree

2 files changed

+41
-0
lines changed

2 files changed

+41
-0
lines changed
Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
From d9d916d5ea946c945323679d1709de1b87029b96 Mon Sep 17 00:00:00 2001
2+
From: Trevor Gamblin <[email protected]>
3+
Date: Tue, 13 Aug 2024 11:07:05 -0400
4+
Subject: [PATCH] test_readline: skip limited history test
5+
6+
This test was added recently and is failing on the ptest image. Disable
7+
it until the proper fix is determined.
8+
9+
See also: https://github.com/python/cpython/issues/121160
10+
11+
Upstream-Status: Inappropriate [OE-specific]
12+
13+
Signed-off-by: Trevor Gamblin <[email protected]>
14+
---
15+
Lib/test/test_readline.py | 2 ++
16+
1 file changed, 2 insertions(+)
17+
18+
diff --git a/Lib/test/test_readline.py b/Lib/test/test_readline.py
19+
index 91fd7dd13f9..d81f9bf8eed 100644
20+
--- a/Lib/test/test_readline.py
21+
+++ b/Lib/test/test_readline.py
22+
@@ -132,6 +132,7 @@ def test_nonascii_history(self):
23+
self.assertEqual(readline.get_history_item(1), "entrée 1")
24+
self.assertEqual(readline.get_history_item(2), "entrée 22")
25+
26+
+ @unittest.skip("Skipping problematic test")
27+
def test_write_read_limited_history(self):
28+
previous_length = readline.get_history_length()
29+
self.addCleanup(readline.set_history_length, previous_length)
30+
@@ -349,6 +350,7 @@ def test_history_size(self):
31+
self.assertEqual(len(lines), history_size)
32+
self.assertEqual(lines[-1].strip(), b"last input")
33+
34+
+ @unittest.skip("Skipping problematic test")
35+
def test_write_read_limited_history(self):
36+
previous_length = readline.get_history_length()
37+
self.addCleanup(readline.set_history_length, previous_length)
38+
--
39+
2.39.2
40+

meta/recipes-devtools/python/python3_3.12.5.bb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ SRC_URI = "http://www.python.org/ftp/python/${PV}/Python-${PV}.tar.xz \
3333
file://0001-gh-107811-tarfile-treat-overflow-in-UID-GID-as-failu.patch \
3434
file://0001-test_deadlock-skip-problematic-test.patch \
3535
file://0001-test_active_children-skip-problematic-test.patch \
36+
file://0001-test_readline-skip-limited-history-test.patch \
3637
"
3738

3839
SRC_URI:append:class-native = " \

0 commit comments

Comments
 (0)