fixup! update forwarding log messages

Author: SergioSim

src/ralph/api/forwarding.py

@@ -16,15 +16,15 @@ def get_active_xapi_forwardings() -> list[XapiForwardingConfigurationSettings]:
 
     active_forwardings = []
     if not settings.XAPI_FORWARDINGS:
-        logger.info("No xAPI forwarding is configured; forwarding is disabled.")
+        logger.info("No xAPI forwarding configured; forwarding is disabled.")
         return active_forwardings
 
     for forwarding in settings.XAPI_FORWARDINGS:
         if forwarding.is_active:
             active_forwardings.append(forwarding)
             continue
         msg = (
-            "The RALPH_XAPI_FORWARDINGS configuration value: '%s' is not activated. "
+            "The RALPH_XAPI_FORWARDINGS configuration value: '%s' is not active. "
             "It will be ignored."
         )
         logger.info(msg, forwarding)
@@ -49,4 +49,4 @@ async def forward_xapi_statements(statements: list[dict]):
                 msg = "Forwarded %s statements to %s with success."
                 logger.debug(msg, len(statements), forwarding.url)
             except (RequestError, HTTPStatusError) as error:
-                logger.warning("Failed to forward xAPI statements. %s", error)
+                logger.error("Failed to forward xAPI statements. %s", error)

tests/api/test_forwarding.py

@@ -59,7 +59,7 @@ def test_api_forwarding_get_active_xapi_forwardings_with_empty_forwardings(
     configuration, should log that forwarding is inactive and return an empty list.
     """
 
-    expected_log = "No xAPI forwarding is configured; forwarding is disabled."
+    expected_log = "No xAPI forwarding configured; forwarding is disabled."
     # RALPH_XAPI_FORWARDINGS not set
     monkeypatch.delenv("RALPH_XAPI_FORWARDINGS", raising=False)
     monkeypatch.setattr("ralph.api.forwarding.settings", Settings())
@@ -108,7 +108,7 @@ def test_api_forwarding_get_active_xapi_forwardings_with_inactive_forwardings(
 
     msg = (
         f"The RALPH_XAPI_FORWARDINGS configuration value: '{inactive_forwarding}' is "
-        "not activated. It will be ignored."
+        "not active. It will be ignored."
     )
     assert len(caplog.record_tuples) == 1
     assert caplog.record_tuples[0][2] == msg
@@ -163,6 +163,7 @@ async def post_success(*args, **kwargs):  # pylint: disable=unused-argument
     monkeypatch.setenv("RALPH_XAPI_FORWARDINGS", f"[{forwarding.json()}]")
     monkeypatch.setattr("ralph.api.forwarding.settings", Settings())
 
+    caplog.clear()
     with caplog.at_level(logging.DEBUG):
         asyncio.get_event_loop().run_until_complete(forward_xapi_statements(statements))
 
@@ -205,7 +206,7 @@ async def post_fail(*args, **kwargs):  # pylint: disable=unused-argument
     monkeypatch.setenv("RALPH_XAPI_FORWARDINGS", f"[{forwarding.json()}]")
     monkeypatch.setattr("ralph.api.forwarding.settings", Settings())
 
-    with caplog.at_level(logging.DEBUG):
+    with caplog.at_level(logging.ERROR):
         asyncio.get_event_loop().run_until_complete(forward_xapi_statements(statements))
 
     assert ["Failed to forward xAPI statements. Something went wrong."] == [