Option to update vector layers while animating

[ahocevar]

With this option, vector batches will be recreated with every frame.
For animations, this means that vector data won't be clipped to the
extent at which the animation started.

[tschaub]

I think this can be handled separately, but what are your thoughts on making this options available in another way? It feels more natural to have rendering related options (rather than calling them device options). Should this be map level or layer level?

[tschaub]

Missing @type annotation.

[ahocevar]

I'm open to making this available in a different way, but haven't thought of different ways. This pull request may not even be needed - at least for now I used a FeatureOverlay instead, which gives me the desired behavior out of the box.

[tschaub]

Personally, I'm in favor of exposing rendering options assuming we can provide alternate strategies without the code becoming a mess (which is not happening here). I think people will likely develop applications and then discover that they want slightly different behavior - less aggressive tile loading, more frequently updated vector rendering, etc. It will be far easier to modify existing application code by adding rendering related options instead of using entirely different objects (swapping out a vector layer and a vector source for a feature overlay for example).

[elemoine]

Agree @tschaub. In this case I think it should be a vector layer option.

[ahocevar]

I updated this pull request by adding an updateVectorsWhileAnimating option on the map. I think this is in line with the loadTilesWhileAnimating and loadTilesWhileInteracting options, which we also have on the map.

[elemoine]

Previously, we said that would be a per-layer option. What is the reason for using a map option instead?

[ahocevar]

@elemoine: you said that. @tschaub was just asking. The reason was to make it work the same as loadTilesWhileAnimating. But other than with tiles (which are managed by the map), it would be possible to make it a layer setting. It would also be possible to have both: layer setting overrides map setting.

[ahocevar]

I'll also make this work with the other renderers. @elemoine: do you want it on both map and layer, or just layer? You wish we code 😄.

[elemoine]

I just think that a layer option would be more flexible.

[ahocevar]

Cool. Will change.

[ahocevar]

Pull request updated. updateWhileAnimating is now a layer option.

[fredj]

LGTM, thanks Andreas

[elemoine]

Don't you need an @api marker here?

[elemoine]

Please merge.