Re enable rotation button transition #2791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work (-: |
fredj
force-pushed
the
rotate-css-transition
branch
from
9817186 to
81e8250
Compare
|
Thanks for the link, very interesting. |
| @@ -53,11 +53,11 @@ | |||
| .ol-rotate { | |||
| top: .5em; | |||
| right: .5em; | |||
| transition: opacity .25s; | |||
| transition: opacity .25s linear, visibility 0s linear .25s; | |||
There was a problem hiding this comment.
delay has to be reset (& just for visibility): I thought of something like:
.ol-rotate {
transition: opacity .25s linear, visibility 0s linear;
}
.ol-rotate.ol-hidden {
transition: opacity .25s linear, visibility 0s linear .25s;
}
|
Please merge. |
The opacity transition was broken with openlayers#2782
fredj
force-pushed
the
rotate-css-transition
branch
from
81e8250 to
aa23a7b
Compare
fredj
added a commit
that referenced
this pull request
Jan 28, 2015
Re enable rotation button transition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opacity transition was broken with #2782
Tested with FF 32 and chrome 36