Making GetTileCoordFor methods public avaible #2973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am using tilegrid to request elevation data tiles side by side of a raster layer. It would be nice if these two method was public avaible such I could use the tilegrid to convert mouse coordinates to tile coordinates to request backend tiles. The elevation tiles are not shown as a layer directly but rather used to compute and show information in relationship to mouse curser or map view. This would save me the time of adding another tilegrid implementation in my application specific context.
|
+1 We can use @tschaub, any opinion about this? |
|
I just enabled them in my own private build for now. Just wanted to let you know that its working out good. I ported your tilegrid api for internal backend stuff also (c#) https://github.com/s-innovations/gis/tree/master/SInnovations.Gis.TileGrid. We also uses mapproxy in our setup and so far the two grid implementations have great overlap and its been easy for a none gis developer to understand all of it so a big thumbs up from me on the work you guys do. |
|
Please remove the |
|
I agree with making them exportable, but not marked as stable. |
elemoine
pushed a commit
that referenced
this pull request
Dec 1, 2014
Making GetTileCoordFor methods public avaible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using tilegrid to request elevation data tiles side by side of a raster layer. It would be nice if these two method was public avaible such I could use the tilegrid to convert mouse coordinates to tile coordinates to request backend tiles.
The elevation tiles are not shown as a layer directly but rather used to compute and show information in relationship to mouse curser or map view.
This would save me the time of adding another tilegrid implementation in my application specific context.