Use offsetX and offsetY if available

[fredj]

Use the mouse event offsetX and offsetY properties if available instead of computing the value in javascript. See http://www.w3.org/TR/cssom-view/#dom-mouseevent-pagex

Calling goog.style.getRelativePosition will cause a reflow (because getBoundingClientRect is called in this function)

[fredj]

And there's also less temporary goog.math.Coordinate instances created (3 per goog.style.getRelativePosition call)

[fredj]

Thanks for any review

[ahocevar]

I have not done any testing (not on touch devices and not on IE), but from just looking at the code it looks good. If you can confirm that the relevant interactions and gestures still work on all target browsers and especially Windows Mobile devices, then please merge.

[gberaudo]

relative to the viewport.

[gberaudo]

The code is local and looks reasonable.
If it works on popular browsers, I am in favour of merging it.

[elemoine]

I don't get it. getEventPixel returns a pixel position that is relative to the map viewport (map.viewport_). My understanding of screenX and screenY is that they're relative to the screen. Am I missing something here?

[elemoine]

Sorry we're talking about offsetX and offsetY here! Looking again…

[elemoine]

And in the case where event.changedTouches is defined (touchend or touchcancel) why don't we use event.changedTouches[0].offsetX and event.changedTouches[1].offsetY instead of doing our own calculation based on clientX and clientY?

And also, is the else (where we use getRelativePosition) still useful/relevant? If so, in what condition?

[fredj]

And in the case where event.changedTouches is defined (touchend or touchcancel) why don't we > use event.changedTouches[0].offsetX and event.changedTouches[1].offsetY instead of doing our own calculation based on clientX and clientY?

Because offsetX and offsetY are not defined for touch events: http://www.w3.org/TR/touch-events/#touch-interface

And also, is the else (where we use getRelativePosition) still useful/relevant? If so, in what condition?

Yes; firefox (at least) does not provide offsetX and offsetY (see https://bugzilla.mozilla.org/show_bug.cgi?id=69787)

[elemoine]

Thanks @fredj! This is very useful information. Information I'd add as comments in the code before merging! Please merge if you agree.

[elemoine]

Very nice. Thanks a lot for the comments you added to the code. This is very useful I think.